Skip to content

Conversation

@ShahanaFarooqui
Copy link
Collaborator

Changelog-None: Fixes error from tools/check-release.sh

Reference Failed Action: https://github.com/ElementsProject/lightning/actions/runs/19561062579

@ShahanaFarooqui ShahanaFarooqui added this to the v25.12 milestone Nov 22, 2025
@ShahanaFarooqui ShahanaFarooqui changed the title make: Remove printing the version from Makefile make: Remove printing version from Makefile Nov 22, 2025
@rustyrussell
Copy link
Contributor

Can we just filter it out instead? I really like the version printing!

diff --git a/tools/check-release.sh b/tools/check-release.sh
index 90da958a57..85dce03ada 100755
--- a/tools/check-release.sh
+++ b/tools/check-release.sh
@@ -50,7 +50,7 @@ if [ "$HEAD_VERSION" != "$VERSION" ]; then
 fi
 
 # The version tag should match the `make version` target output.
-MAKE_VERSION=$(make version)
+MAKE_VERSION=$(make version | grep -v 'Building version')
 echo "MAKE_VERSION=$MAKE_VERSION"
 if [ "$MAKE_VERSION" != "$VERSION" ]; then
     echo "The version tag must match the \`make version\` target output." >&2

@ShahanaFarooqui
Copy link
Collaborator Author

ShahanaFarooqui commented Nov 23, 2025

Can we just filter it out instead? I really like the version printing!

Thanks for the suggestion! Version printing is helpful for debugging purposes, but I was initially concerned about breaking other scripts if they assume make version returns only a single line. However, since that doesn't appear to be the case, I am keeping the printing as is while capturing only the last line of output from make version. This ensures that future changes to the printed messages—whether editing existing text or adding/removing lines—won't accidentally break this script.

Changelog-None: Fixes error from `tools/check-release.sh`
Copy link
Collaborator

@madelinevibes madelinevibes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! ack 5109506

@madelinevibes madelinevibes merged commit 147ffec into ElementsProject:master Nov 24, 2025
34 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants