Backports and changes to fix CI #1161
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psgreco
force-pushed
the
elements-22-fix-ci
branch
2 times, most recently
from
1ce5299 to
c4d5a2e
Compare
psgreco
force-pushed
the
elements-22-fix-ci
branch
5 times, most recently
from
d991b9f to
f1ddd5d
Compare
psgreco
force-pushed
the
elements-22-fix-ci
branch
4 times, most recently
from
180e5a3 to
67df486
Compare
psgreco
force-pushed
the
elements-22-fix-ci
branch
from
30bce12 to
b298faa
Compare
psgreco
force-pushed
the
elements-22-fix-ci
branch
2 times, most recently
from
bc32ff6 to
a3dff72
Compare
psgreco
force-pushed
the
elements-22-fix-ci
branch
from
a3dff72 to
9ef0265
Compare
psgreco
force-pushed
the
elements-22-fix-ci
branch
2 times, most recently
from
d6e45b5 to
fa51e27
Compare
psgreco
force-pushed
the
elements-22-fix-ci
branch
from
fa51e27 to
adbdb3d
Compare
psgreco
force-pushed
the
elements-22-fix-ci
branch
3 times, most recently
from
31b5de2 to
c06a2e2
Compare
psgreco
force-pushed
the
elements-22-fix-ci
branch
3 times, most recently
from
844b74e to
df4d00f
Compare
psgreco
force-pushed
the
elements-22-fix-ci
branch
from
20e41b9 to
df4e99d
Compare
psgreco
force-pushed
the
elements-22-fix-ci
branch
9 times, most recently
from
789c398 to
8a5545b
Compare
psgreco
force-pushed
the
elements-22-fix-ci
branch
from
8a5545b to
913a587
Compare
Github-Pull: 25237 Rebased-From: 20ff499
Github-Pull: bitcoin/bitcoin#25983 Rebased-From: 4296dde
psgreco
force-pushed
the
elements-22-fix-ci
branch
from
1f2371b to
c151978
Compare
The previous logic would call it once for serializing into the filestream, and then again for serializing into the hasher. If AddrMan was changed in between these calls by another thread, the resulting peers.dat would be corrupt with non-matching checksum and data. Fix this by using HashedSourceWriter, which writes the data to the underlying stream and keeps track of the hash in one go. Github-Pull: #26909 Rebased-From: 5eabb61
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an always draft test PR