Skip to content

set nNonce to Null in CoinsView #1008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

set nNonce to Null in CoinsView #1008

wants to merge 1 commit into from

Conversation

apoelstra
Copy link
Member

@apoelstra apoelstra commented Jun 8, 2021 •
edited
Loading

Alternative to #1006

Fixes #1008

@apoelstra apoelstra mentioned this pull request Jun 8, 2021
Closed
sanket1729
sanket1729 approved these changes Jun 29, 2021
View reviewed changes
Copy link
Member

@sanket1729 sanket1729 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK a70ff3c

@apoelstra
Copy link
Member Author

Lol, some of the new assertions are triggering in CI

@apoelstra
Copy link
Member Author

Sigh, so, the CCoinsView is a base class of two things -- the "UTXO set" which is saved to disk in the coinstate/ directory, where we want to erase the nonce, and the mempool tx db, where we do not want to erase the nonce (and there are existing assertions that prevent us from doing so).

@stevenroose stevenroose mentioned this pull request Nov 25, 2021
Open
@stevenroose
Copy link
Contributor

Any update on solving this?

@roconnor-blockstream
Copy link
Contributor

Why don't we want to erase it from the mempool?

@apoelstra
Copy link
Member Author

@stevenroose no update. I think it might be practically impossible.

@roconnor-blockstream because of tangled inheritance relationships between various mempool-like structures. If you do what you're suggesting you will get far away assertion failures in consensus code where they might be meaningful.

@apoelstra
Copy link
Member Author

I think we should just live with this bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@sanket1729 sanket1729 sanket1729 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@apoelstra @stevenroose @roconnor-blockstream @sanket1729