Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carpet: Added PreSync support in regrid #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rhaas80
Copy link
Member

@rhaas80 rhaas80 commented Aug 8, 2024

@SamuelCupp 's pull request 57 https://bitbucket.org/eschnett/carpet/pull-requests/57

This change adds logic in the regridding to set the validities of all grid functions to be 'interior'. Grid functions which have prolongation set to 'no' should instead be set to 'nowhere', but this is not yet implemented.

This change adds logic in the regridding to set the validities
of all grid functions to be 'interior'. Grid functions which have
prolongation set to 'no' should instead be set to 'nowhere', but
this is not yet implemented.
@rhaas80 rhaas80 requested a review from SamuelCupp August 8, 2024 22:07
@@ -299,6 +299,26 @@ void CallRegrid(cGH *const cctkGH) {
ENTER_LEVEL_MODE(cctkGH, rl) {
BeginTimingLevel(cctkGH);

int num_groups = CCTK_NumGroups();
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indentation is all wrong

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has not been applied, and the indentation is still all wrong.

@rhaas80 rhaas80 requested a review from stevenrbrandt January 16, 2025 21:25
@rhaas80
Copy link
Member Author

rhaas80 commented Jan 16, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants