fix(dropddown): accessibility fix for dropdown options via Tab and arrow keys #1084
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY:
Dropdown options can be navigated using both Tab and Arrow keys.
shouldCloseOnTab prop has been introduced,
By default, this prop is set to false, so pressing the Tab key does not close the dropdown and focus moves within the options
To make the dropdown close via Tab key, pass the shouldCloseOnTab prop
GITHUB ISSUE (Open Source Contributors)
JIRA TASK (Eightfold Employees Only):
CHANGE TYPE:
TEST COVERAGE:
TEST PLAN:
Navigate to any dropdown
By default, the dropdown options are accessible using the Arrow keys and Tab
Pressing the Tab key focus moves inside the dropdown options
To make the dropdown close via Tab key, pass the shouldCloseOnTab prop
Screen.Recording.2026-01-02.at.4.07.11.PM.mov