Skip to content

Conversation

@mfazil-eightfold
Copy link
Contributor

@mfazil-eightfold mfazil-eightfold commented Jan 2, 2026

SUMMARY:

Fixed accessibility issues in the Octuple Upload component by automatically generating accessible delete/remove button labels that include the filename. Delete/remove buttons now have aria-labels like "Delete file example.pdf" (or localized equivalent), improving screen reader announcements.

image

Changes:

  • Auto-generated aria-label with filename for all remove buttons
  • Works across all list types (text, picture, picture-card)
  • Respects existing i18n using localized removeFileText
  • Preserves existing behavior where aria-label is null for specific configurations

Files Modified:

  • src/components/Upload/UploadList/ListItem.tsx - Updated remove button aria-label to include filename

GITHUB ISSUE (Open Source Contributors):

JIRA TASK (Eightfold Employees Only):

https://eightfoldai.atlassian.net/browse/ENG-167698

CHANGE TYPE:

  • Bugfix Pull Request
  • Feature Pull Request

TEST COVERAGE:

  • Tests for this change already exist
  • I have added unittests for this change

TEST PLAN:

Manual Testing:

  1. Upload files in all list types (text, picture, picture-card) and verify remove button aria-label includes filename
  2. Test with multiple files and verify each remove button has correct filename
  3. Test edge cases: long filenames, special characters, files without extensions
  4. Test with different locales to verify i18n works correctly
  5. Test with screen readers (NVDA/JAWS/VoiceOver) to verify announcements
  6. Verify existing functionality is not broken (regression check)

Automated Testing:

  • Add unit tests to verify aria-label includes filename
  • Add tests for all list types and edge cases
  • Add i18n tests for localized strings
  • Update existing accessibility tests
  • Verify no accessibility violations in automated a11y scans

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 2, 2026

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant