fix: prevent slider thumbs from being keyboard focusable when readonly or disabled #1082
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY:
Fixes accessibility issue where slider thumbs (
<input type="range">elements) remained keyboard focusable even when the slider was inreadOnlyordisabledstate. This prevented users from skipping non-interactive sliders during keyboard navigation.GITHUB ISSUE (Open Source Contributors)
N/A
JIRA TASK (Eightfold Employees Only):
https://eightfoldai.atlassian.net/browse/ENG-164476
CHANGE TYPE:
TEST COVERAGE:
TEST PLAN:
Automated Tests
✅ Added 2 new unit tests in
Slider.test.tsx:tabIndex="-1"is set on thumb inputs when slider isreadOnlyordisabledtabIndexattribute is not present on thumb inputs when slider is interactive✅ All existing tests pass
Manual Testing
Test readonly slider:
readOnly={true}Test disabled slider:
disabled={true}Test interactive slider:
Test range slider:
readOnly={true}