Skip to content

Conversation

@kheinrich-eightfold
Copy link
Contributor

@kheinrich-eightfold kheinrich-eightfold commented Dec 2, 2025

SUMMARY:

This PR fixes an accessibility issue surfaced in a few place in the UI with associated JIRA tickets.

GITHUB ISSUE (Open Source Contributors)

JIRA TASK (Eightfold Employees Only):

https://eightfoldai.atlassian.net/browse/ENG-162951
https://eightfoldai.atlassian.net/browse/ENG-162959
https://eightfoldai.atlassian.net/browse/ENG-162978
https://eightfoldai.atlassian.net/browse/ENG-163006
https://eightfoldai.atlassian.net/browse/ENG-163088

CHANGE TYPE:

  • Bugfix Pull Request
  • Feature Pull Request

TEST COVERAGE:

  • Tests for this change already exist
  • I have added unittests for this change

TEST PLAN:

@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 2, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@codecov
Copy link

codecov bot commented Dec 2, 2025

Codecov Report

❌ Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.12%. Comparing base (15996a2) to head (7ead6e6).

Files with missing lines Patch % Lines
src/components/Dropdown/Dropdown.tsx 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1055      +/-   ##
==========================================
+ Coverage   84.10%   84.12%   +0.01%     
==========================================
  Files        1146     1146              
  Lines       20942    20940       -2     
  Branches     7921     7921              
==========================================
+ Hits        17614    17616       +2     
+ Misses       3240     3236       -4     
  Partials       88       88              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants