Skip to content

Change Number.parse to parseFloat in schema migration #6811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
danielo515 wants to merge 3 commits into
base: main
Choose a base branch
from
+3 −3
Open

Change Number.parse to parseFloat in schema migration #6811

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ddadd6b
Change Number.parse to parseFloat in schema migration
danielo515 Jul 31, 2026
2214a1d
address PR comments
danielo515 Jul 31, 2026
ebecf28
chore: use better variable names
danielo515 Jul 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions migration/schema.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -903,11 +903,11 @@ import { Effect, Number, Option, Schema, SchemaGetter, SchemaIssue } from "effec
const NumberFromString = Schema.String.pipe(
Schema.decodeTo(Schema.Number, {
decode: SchemaGetter.transformOrFail((s) => {
const n = Number.parse(s)
if (n === undefined) {
const parsed = parseFloat(s)
if (isNaN(parsed)) {
Comment thread
danielo515 marked this conversation as resolved.
return Effect.fail(new SchemaIssue.InvalidValue(Option.some(s)))
}
return Effect.succeed(n)
return Effect.succeed(parsed)
}),
encode: SchemaGetter.String()
})
Expand Down
Loading