Cleanup/remove performance mode divergence#446
Draft
Edwardvaneechoud wants to merge 5 commits intomainfrom
Draft
Cleanup/remove performance mode divergence#446Edwardvaneechoud wants to merge 5 commits intomainfrom
Edwardvaneechoud wants to merge 5 commits intomainfrom
Conversation
✅ Deploy Preview for flowfile-wasm canceled.
|
✅ Deploy Preview for flowfile-wasm canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request removes all support for the "optimized virtual-table plan" storage and preview path, simplifying the handling of virtual tables in the catalog. The migration drops related database columns, removes associated code paths, and ensures that virtual tables no longer attempt to provide data previews (the UI will show a placeholder instead). Only the "is_optimized" flag is retained as a derived indicator for laziness propagation.
Database and schema changes:
serialized_lazy_frame,polars_plan, andsource_table_versionscolumns from thecatalog_tablestable, removing storage for optimized virtual-table plans. (flowfile_core/alembic/versions/010_drop_optimized_plan_columns.py)Removal of optimized virtual-table plan logic:
Removes all code related to storing, updating, and previewing optimized virtual-table plans, including parameters and attributes for
serialized_lazy_frame,polars_plan, andsource_table_versionsfrom service and model layers. (flowfile_core/catalog/service.py,flowfile_core/catalog/services/virtual_tables.py,flowfile_core/catalog/services/tables.py) [1] [2] [3] [4] [5] [6] [7] [8] [9]Removes the
check_source_versions_currentfunction and all logic related to checking or hashing source table versions. (flowfile_core/catalog/delta_utils.py,flowfile_core/catalog/text_utils.py,flowfile_core/catalog/services/sql.py) [1] [2] [3]Virtual table preview simplification:
flowfile_core/catalog/services/previews.py,flowfile_core/catalog/service.py) [1] [2] [3] [4] [5] [6]Code cleanup:
flowfile_core/catalog/services/virtual_tables.py,flowfile_core/catalog/service.py) [1] [2] [3]These changes remove legacy code and storage related to optimized virtual-table plans, streamlining the virtual table implementation and reducing maintenance overhead.