Skip to content

Fix stack overflow in calculateLatestCheckpoint #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
samholmes merged 1 commit into from
Mar 10, 2026
Merged

Fix stack overflow in calculateLatestCheckpoint #95

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
# edge-sync-server

## Unreleased

- fixed: Fixed call-stack overflow bug when calculating latest checkpoint.
7 changes: 4 additions & 3 deletions src/util/store/syncing.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,9 +171,10 @@ const calculateLatestCheckpoint = (
// Remove any previous document versions being overwritten.
// If there exists versions that are lower or equal than the current
// checkpoint version, then the max is the previous version.
const previousVersion = Math.max(
0,
...document.versions.filter(version => version <= checkpoint.version)
const previousVersion = document.versions.reduce(
(max, version) =>
version <= checkpoint.version && version > max ? version : max,
0
)
// Add latest version and subtract previous version.
return sum + document.versions[0] - previousVersion
Expand Down
Loading