feat: add home screen long-press shortcuts via expo-quick-actions #6001
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,4 @@ | ||
| import 'expo-modules-core' | ||
| import 'react-native-gesture-handler' | ||
| import './src/app' | ||
| import './src/perf' | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| import * as QuickActions from 'expo-quick-actions' | ||
| import { useQuickActionCallback } from 'expo-quick-actions/hooks' | ||
| import * as React from 'react' | ||
| import { Linking, Platform } from 'react-native' | ||
|
|
||
| import { useHandler } from '../../hooks/useHandler' | ||
| import { lstrings } from '../../locales/strings' | ||
| import { showError } from './AirshipInstance' | ||
|
|
||
| const DO_NOT_UNINSTALL_URL = | ||
| 'https://support.edge.app/en/articles/14439418-warning-don-t-uninstall-edge-without-your-login-credentials' | ||
| const CONTACT_SUPPORT_URL = | ||
| 'https://support.edge.app/en/articles/14054649-need-help-reach-out-via-our-chat-bubble?chat=open' | ||
|
|
||
| export const QuickActionsManager: React.FC = () => { | ||
| React.useEffect(() => { | ||
| QuickActions.setItems([ | ||
| { | ||
| id: 'do_not_uninstall', | ||
| title: lstrings.shortcut_do_not_uninstall_title, | ||
| subtitle: lstrings.shortcut_do_not_uninstall_subtitle, | ||
| icon: Platform.select({ | ||
| ios: 'symbol:nosign', | ||
| default: 'prohibit' | ||
| }), | ||
| params: { url: DO_NOT_UNINSTALL_URL } | ||
| }, | ||
| { | ||
| id: 'contact_support', | ||
| title: lstrings.shortcut_contact_support_title, | ||
| subtitle: lstrings.shortcut_contact_support_subtitle, | ||
| icon: Platform.select({ | ||
| ios: 'symbol:message.fill', | ||
| default: 'message' | ||
| }), | ||
| params: { url: CONTACT_SUPPORT_URL } | ||
| } | ||
| ]).catch(showError) | ||
| }, []) | ||
|
|
||
| const handleQuickAction = useHandler((action: QuickActions.Action) => { | ||
| const url = action.params?.url | ||
| if (typeof url === 'string') { | ||
| Linking.openURL(url).catch(showError) | ||
|
Contributor
There was a problem hiding this comment. Instead of sending the user to the browser could we launch the app with a deeplink to a special scene? I don't think it's appropriate to put links to our support pages with our branding in the quick actions of our white label apps. If we deeplink into a scene it can remain themed and use strings with the white label name in them |
||
| } | ||
| }) | ||
|
|
||
| useQuickActionCallback(handleQuickAction) | ||
|
|
||
| return null | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shorthand
.catch(showError)loses stack tracesLow Severity
Both
.catch(showError)calls (onQuickActions.setItems(…)andLinking.openURL(url)) use the shorthand form that loses the calling-site stack trace. The project convention (and other service files likeServices.tsxandContactsLoader.ts) consistently use.catch((error: unknown) => showError(error))instead. This violates thepreserve-stack-tracesrule.Additional Locations (1)
src/components/services/QuickActionsManager.tsx#L43-L44Reviewed by Cursor Bugbot for commit 4bec8ad. Configure here.