Support multiple RPC urls for EvmRpc #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swansontec
requested changes
Nov 21, 2025
src/plugins/evmRpc.ts
Outdated
| const { pluginId, urls, scanAdapters } = opts | ||
|
|
||
| // Use random URL for logging if safeUrl not provided | ||
| const safeUrl = opts.safeUrl ?? pickRandom(urls) |
Contributor
There was a problem hiding this comment.
The whole "safeUrl" concept needs to go away. The idea was to present both the "real" URL with the API key, and the "safe" URL with the API key redacted. But now that we have an array of URL's, we'd either need to (from worse to better):
- Have a matching array of safe URL's. Kinda annoying.
- Stop caring about logging API keys. If somebody can access our box, they can just read the keys from the config anyhow. This is only a problem if we integrate Loki or something.
- Use a regexp to sanitize URL's.
- Use the same
https://somebody?apiKey={{keyName}}syntax we use in accountbased, and then substitute the API key for thefetchcall, but leave it un-substituted for logging.
I leave it up to you how to address this. It's not even clear that we have API keys in any of the URL's, in which case 2 might be a sensible choice.
| url: 'https://polygon-amoy-bor-rpc.publicnode.com' | ||
| urls: [ | ||
| 'https://api.zan.top/polygon-amoy', // yellow privacy | ||
| 'https://polygon-amoy-public.nodies.app', // yellow privacy |
Contributor
There was a problem hiding this comment.
What's with all these privacy comments?
Contributor
Author
There was a problem hiding this comment.
These are from chainlist.org. They're there to verify sorting by privacy first (green).
- Remove safeUrl parameter from BlockbookOptions and EvmRpcOptions interfaces - Add sanitizeUrlForLogging utility function that removes API keys from URLs - Use sanitization function in blockbook plugin (API keys are added to URLs) - Stub sanitization function in evmRpc plugin with TODO (API keys not yet used for RPC URLs) - Remove safeUrl usage from allPlugins.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneDescription
none