ECWID-172338 Option and attribute names are masked in logs #525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
mplain
reviewed
Oct 9, 2025
mplain
reviewed
Oct 9, 2025
…general name key value pattern from secure patterns, added specific patterns for billingPerson, personInfo, and shippingAddress
…w test for secure pattern with name parametr, changed the previous tests using the createSecurePatterns() method, updated the expected result since the unmaskedLength was modified to the default value of 6
maratmiribyan
force-pushed
the
ECWID-172338
branch
from
6611334 to
7a01ff6
Compare
AleksandrSharikov
approved these changes
Oct 13, 2025
mplain
approved these changes
Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removed general name pattern from secure patterns,
added specific patterns for billingPerson, personInfo, and shippingAddress,
added test for string with name parameter