ECWID-172634: Add a new field in OrderForCalculate to check if the request came from Order Editor. #521
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…quest came from Order Editor.
zont163
requested changes
Sep 19, 2025
| val giftCardRedemption: Double? = null, | ||
| val totalBeforeGiftCardRedemption: Double? = null, | ||
| val giftCardDoubleSpending: Boolean? = null, | ||
| val fromOE: Boolean? = false, |
There was a problem hiding this comment.
а нам точно нужно такое поле? По appId мы не можем определить, что запрос пришел именно от OE?
There was a problem hiding this comment.
и что скрывается под этим полем? это ж публичное апи. вдруг кто-то еще захочет воспользоваться этим полем? как они поймут что им нужно именно оно?
скорее всего название поля должно отражать суть того, как оно повлияет на результаты расчета.
There was a problem hiding this comment.
Да, посмотрела, внутри запроса уже приходит имя app-а. Так что закрою этот ПР.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.