fix(parser): exclude layer_name from nodeAttributeNames#65
Merged
Conversation
Every node object carries layer_name as the structural pointer to its layer (used to build stateNodeMap, nodesPerLayer, etc.). It was leaking into the colour-by / size-by dropdowns because the exclusion list in parseMultilayerData was missing it — state-node and layer extraction already excluded it, only the node-attribute line had the omission. Test 6.1 in dataParser.test.js gains a regression assertion. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
(used to build stateNodeMap, nodesPerLayer, etc.), but it was leaking into
the colour-by / size-by dropdowns.
state-node line (135) and layer line (137) already had it.
Test plan
npm test— all 225 vitest unit tests passno longer list
layer_name