-
Notifications
You must be signed in to change notification settings - Fork 265
Use separate jobs instead of child_process #881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
3a405c3
to
66976d2
Compare
66976d2
to
7420c17
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
hi @amvanbaren, do you know why this is failed https://github.com/EclipseFdn/publish-extensions/actions/runs/15301776884/job/43043958569?pr=881 |
The reporting functionality is broken: publish-extensions/.github/workflows/publish-extensions.yml Lines 50 to 77 in 7420c17
There's a check for important extensions: https://github.com/EclipseFdn/publish-extensions/blob/f7cfb5c517bbf53d772704383db8b22b4cb895aa/report-extensions.ts#L226C1-L232C2 Because the reporting functionality is broken every extension is seen as outdated and the Validate PR job fails. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, I'm aligned and happy with this approach --> we never really did publishing outside of GitHub Actions anyway.
I'm curious about:
- How does our local testing story look like? I used to run
node publish-extension.js
with a list of extensions when debugging build issues with certain extensions - How can we test the PR before landing it? If it's not worth the effort to do here, I'm also fine with merging it and testing then
- Do we have an idea on how this will affect timing? I know there's some concurrency limits for GHA workflows, so given there's > 400 extensions, I worry the publishing times might get lengthy.
const publishContext = JSON.parse(process.env.PUBLISH_CONTEXT); | ||
publishContext.msLastUpdated = new Date(publishContext.msLastUpdated); | ||
publishContext.ovsxLastUpdated = new Date(publishContext.ovsxLastUpdated); | ||
await resolveExtension( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does resolveExtension
have a side effect we need here or can we safely remove it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, I like finally not having everything in the root 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please run npm run format
here?
This PR introduces the use of separate jobs instead of child_process to sandbox the extension build process.