Update extensions.json #842
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add pyrefly to open vsx registry per suggestion [here](facebook/pyre-check#975 (comment))
facebook-github-bot
pushed a commit
to facebook/pyrefly
that referenced
this pull request
Mar 21, 2025
Summary:
This diff adds a deploy_extensions github action which will deploy the extension on any changes to `pyre2/version.bzl`. This diff also switches the build action to use the version in `pyre2/version.bzl` so the extension version should always match the language server version in the marketplace.
To manually update the extension, developers should update the version in version.bzl (see the doc comment).
The version in `package.json` is not relevant because the build_extension action builds a specific version (`npx vsce package <platform> <version>`). this command updates package.json locally but does not get committed (if we don't want it modified we can `--no-update-package-json` on `npx vsce package` but I don't think it matters). if we want this to always be up to date with pyre2/version.bzl I can do that (I don't know if it matters).
Users of the extension should generally be disabling auto update and selecting a specific version of the extension (matching their pypy version) if they want to stay in sync with an old version.
{F1976279886}
I also opened a PR [here](EclipseFdn/publish-extensions#842) in order to make it [available in the open VSX registry](facebook/pyre-check#975 (comment))
Reviewed By: stroxler
Differential Revision: D71577667
fbshipit-source-id: 74e28230cf5bb1c6a33d72ad4f74f710277dbd77
facebook-github-bot
pushed a commit
to facebook/pyre-check
that referenced
this pull request
Mar 21, 2025
Summary:
This diff adds a deploy_extensions github action which will deploy the extension on any changes to `pyre2/version.bzl`. This diff also switches the build action to use the version in `pyre2/version.bzl` so the extension version should always match the language server version in the marketplace.
To manually update the extension, developers should update the version in version.bzl (see the doc comment).
The version in `package.json` is not relevant because the build_extension action builds a specific version (`npx vsce package <platform> <version>`). this command updates package.json locally but does not get committed (if we don't want it modified we can `--no-update-package-json` on `npx vsce package` but I don't think it matters). if we want this to always be up to date with pyre2/version.bzl I can do that (I don't know if it matters).
Users of the extension should generally be disabling auto update and selecting a specific version of the extension (matching their pypy version) if they want to stay in sync with an old version.
{F1976279886}
I also opened a PR [here](EclipseFdn/publish-extensions#842) in order to make it [available in the open VSX registry](#975 (comment))
Reviewed By: stroxler
Differential Revision: D71577667
fbshipit-source-id: 74e28230cf5bb1c6a33d72ad4f74f710277dbd77
|
Hi @kinto0 👋, as per our contributing guidelines:
The above also includes owners, who should publish the extension from their respective repositories instead of this one, so that they own the publishing process from end to end and reduce the maintenance burden on this repository. Let me know if you have any questions, happy to assist with setting up the pipeline on your end. I also see that you already have a pipeline for publishing to the Microsoft Marketplace: https://github.com/facebook/pyre-check/blob/main/pyre2/.github/workflows/deploy_extension.yml. This is awesome, and means that setting up publishing to Open VSX (besides getting an access token as described in the Wiki article) should be as easy as using |
facebook-github-bot
pushed a commit
to facebook/pyrefly
that referenced
this pull request
Apr 3, 2025
Summary: [issue](facebook/pyre-check#975 (comment)) I mistakenly tried adding support from [this](EclipseFdn/publish-extensions#842 (comment)) repo. Instead we should be doing it ourselves. Reviewed By: stroxler Differential Revision: D72345263 fbshipit-source-id: 9f9084282048749dab5119caa0afdc8be663b885
facebook-github-bot
pushed a commit
to facebook/pyre-check
that referenced
this pull request
Apr 4, 2025
Summary: [issue](#975 (comment)) I mistakenly tried adding support from [this](EclipseFdn/publish-extensions#842 (comment)) repo. Instead we should be doing it ourselves. Reviewed By: stroxler Differential Revision: D72345263 fbshipit-source-id: 9f9084282048749dab5119caa0afdc8be663b885
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Per suggestion here, we would like our vscode extension available here.