This repository was archived by the owner on Dec 11, 2019. It is now read-only.
Fixes to make the org selection more flexable - #31
Open
eclipsewebmaster wants to merge 1 commit into
Open
Conversation
…based on the org root Signed-off-by: Eclipse Webmaster <webmaster@eclipse.org>
| if ( preg_match('/eclipse/',$org) !== 1 ){ | ||
| echo "Not eclipse, skipping issues processing\n"; | ||
| #only work with selected orgs based on the config file | ||
| if ( preg_match(GITHUB_ORG_REGEX,$github_organization) !== 1 ){ |
Contributor
Author
There was a problem hiding this comment.
Where is this defined?
Contributor
Author
There was a problem hiding this comment.
In the config file. That allows us to expand the covered organizations without further code changes.
| #teamnames are important and need to be updated based on the org name in order for follow on processing to find them | ||
| #for 'sub' orgs(eclipse-ee4j) they should simply use the 'parent' org name for the first half of the team name | ||
| $orgNameParts= explode("-",$teamRepoOrg[0]); | ||
| if ( preg_match("/$orgNameParts[0]/",$teamName) !==1 ){ |
Contributor
Author
There was a problem hiding this comment.
Does $ fly in preg_match for including variables? I thought it would need to be escaped.
Contributor
Author
There was a problem hiding this comment.
The docs don't indicate that this isn't valid, and it does work. But I'll concede that may be a happy accident. Adding Chris, for comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And update team names based on the org root
Signed-off-by: Eclipse Webmaster webmaster@eclipse.org