Skip to content

Implement Maniacs Battle Common Events (Second Try)#3545

Draft
Ghabry wants to merge 2 commits into
EasyRPG:masterfrom
Ghabry:maniac-battle
Draft

Implement Maniacs Battle Common Events (Second Try)#3545
Ghabry wants to merge 2 commits into
EasyRPG:masterfrom
Ghabry:maniac-battle

Conversation

@Ghabry
Copy link
Copy Markdown
Member

@Ghabry Ghabry commented May 16, 2026

See #3307 with the difference that it hooks directly into our Game_CommonEvent class to make the parallel events execute as intended.

Imo this is closer than #3307 but still not perfect, especially when the Parallel events show messages. When no messages are shown it appears to be... okay (?)


I need testers for this! I don't really know of alot of games that use this Battle stuff and are not 100 million lines of event voodoo. So this is hard to test.

Your task: Throw this Player PR at games that use this feature and even better figure out where it fails in the event code.

When I don't get enough useful reports this PR will never be merged as I won't integrate untested code into the Player. Thank you for your attention.


Also noticed a bug in the Get ATB function: It must return the percentage

Ghabry and others added 2 commits May 16, 2026 18:49
The execution order appears to be correct for parallel events.
They match the examples from EasyRPG#3307

What is not working correctly is showing of message boxes
In Maniacs they halt the battle while we continue the battle for one frame
everytime it is closed.

Co-Authored-By: Dino Suvalic <82914521+MakoInfused@users.noreply.github.com>
@jetrotal
Copy link
Copy Markdown
Contributor

I wonder if gobble fantasy uses it:

https://dogs-understand.itch.io/gobble-fantasy-2003

image

From what I read, it uses maniacs to force atb to work as a turn based battle

@Ghabry
Copy link
Copy Markdown
Member Author

Ghabry commented May 17, 2026

Nope:

> grep trigger RPG_RT.edb | sort | uniq -c
      4     <trigger>3</trigger>
     53     <trigger>4</trigger>
    217     <trigger>5</trigger>

Start is 6, Battle Parallel is 7

@korean-guy
Copy link
Copy Markdown

When I simply tested it, it seems to behave the same as #3307 .
I haven't checked it in #3307 , but I tested the ATB gauge in this PR.
If member[1].gauge is output as a variable value, it is output as a percentage,
When the ATB value is obtained from the Control Battle command, it is output as a numerical value, not as a percentage.
I don't know if this was meant to be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants