Implement Maniacs Battle Common Events (Second Try)#3545
Draft
Ghabry wants to merge 2 commits into
Draft
Conversation
The execution order appears to be correct for parallel events. They match the examples from EasyRPG#3307 What is not working correctly is showing of message boxes In Maniacs they halt the battle while we continue the battle for one frame everytime it is closed. Co-Authored-By: Dino Suvalic <82914521+MakoInfused@users.noreply.github.com>
Contributor
|
I wonder if gobble fantasy uses it: https://dogs-understand.itch.io/gobble-fantasy-2003
From what I read, it uses maniacs to force atb to work as a turn based battle |
Member
Author
|
Nope: Start is 6, Battle Parallel is 7 |
|
When I simply tested it, it seems to behave the same as #3307 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

See #3307 with the difference that it hooks directly into our
Game_CommonEventclass to make the parallel events execute as intended.Imo this is closer than #3307 but still not perfect, especially when the Parallel events show messages. When no messages are shown it appears to be... okay (?)
I need testers for this! I don't really know of alot of games that use this Battle stuff and are not 100 million lines of event voodoo. So this is hard to test.
Your task: Throw this Player PR at games that use this feature and even better figure out where it fails in the event code.
When I don't get enough useful reports this PR will never be merged as I won't integrate untested code into the Player. Thank you for your attention.
Also noticed a bug in the Get ATB function: It must return the percentage