TSM-04: convert core entry and shared infra to TypeScript - #561
Conversation
Justin Hammond (Justintime50)
changed the title
0af98c1 to
de5a155
Compare
58095f6 to
97ce5ac
Compare
9ef2479 to
809c70a
Compare
809c70a to
52b267f
Compare
52b267f to
d3aceac
Compare
d3aceac to
a1c30e4
Compare
Alex Matthews (ralexmatthews)
left a comment
Alex Matthews (ralexmatthews)
left a comment
There was a problem hiding this comment.
Nice, mostly looks good. I would just strongly suggest keeping noImplicitAny disabled here.
Would also suggest stronger types on the client options, but that one is nonblocking.
Alex Matthews (ralexmatthews)
left a comment
Alex Matthews (ralexmatthews)
left a comment
There was a problem hiding this comment.
Looks good. Like the better clientoptions type. Looking forward to disabling that noImplicitAnys option though
| type ClientOptions = { | ||
| apiKey?: string; | ||
| useProxy?: boolean; | ||
| timeout?: number; | ||
| baseUrl?: string; | ||
| httpMiddleware?: HttpMiddleware; | ||
| requestMiddleware?: RequestMiddleware; | ||
| httpClient?: HttpClient; | ||
| }; |
There was a problem hiding this comment.
Siiiiick 🔥
| method: string = EasyPostClient.METHODS.GET, | ||
| params: Record<string, unknown> = {}, | ||
| headers: RequestHeaders = {}, | ||
| ): Promise<any> { |
There was a problem hiding this comment.
question:
Do we wanna make this return unknown to be consistent with the others above? Or is that part of the "strengthening the any's" you referenced?
There was a problem hiding this comment.
You may want to cross reference any questions with the end state, lots of changes kept happening up the stack too (unfortunate I know, but it's possible that these got tightened/corrected in a later PR)
3 participants
Summary
Validation