Skip to content

TSM-02: Add CJS/ESM export compatibility test - #558

Merged
Justin Hammond (Justintime50) merged 2 commits into
ts-migrate/01-ts-build-scaffoldingfrom
ts-migrate/02-package-export-readiness
Sep 1, 2026
Merged

TSM-02: Add CJS/ESM export compatibility test#558
Justin Hammond (Justintime50) merged 2 commits into
ts-migrate/01-ts-build-scaffoldingfrom
ts-migrate/02-package-export-readiness

Conversation

@Justintime50

@Justintime50 Justin Hammond (Justintime50) commented Aug 6, 2026

Copy link
Copy Markdown
Member

Summary

Implements topology item 2 by adding explicit package export compatibility coverage for both CJS and ESM consumption paths.

Changes in this PR

  • adds test/services/module_exports_compat.test.js.
  • validates CommonJS require('../..') returns constructable client.
  • validates ESM import('../..') default export returns constructable client.

Testing

  • npx vitest run test/services/module_exports_compat.test.js

Stack Context

Depends on PR #557.

@Justintime50
Justin Hammond (Justintime50) force-pushed the ts-migrate/02-package-export-readiness branch from be693fd to 60d3e85 Compare August 6, 2026 21:07
@Justintime50 Justin Hammond (Justintime50) changed the title TSM-02: add CJS/ESM export compatibility test TSM-02: Add CJS/ESM export compatibility test Aug 6, 2026
@Justintime50
Justin Hammond (Justintime50) force-pushed the ts-migrate/02-package-export-readiness branch 3 times, most recently from a9eb4be to b3e282a Compare August 7, 2026 19:49
@Justintime50
Justin Hammond (Justintime50) force-pushed the ts-migrate/02-package-export-readiness branch from b3e282a to eb35df3 Compare August 7, 2026 19:54

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@Justintime50
Justin Hammond (Justintime50) marked this pull request as ready for review August 12, 2026 20:27
@Justintime50
Justin Hammond (Justintime50) merged commit 4cf2f78 into master Sep 1, 2026
33 checks passed
@Justintime50
Justin Hammond (Justintime50) deleted the ts-migrate/02-package-export-readiness branch September 1, 2026 20:50
Justin Hammond (Justintime50) added a commit that referenced this pull request Sep 1, 2026
## Summary

> NOTE: The `dev-docs` in this PR can mostly be ignored as it was used
to steer the agent during this entire stack development, but can be
reviewed if desired (is later removed as it's not intended to stay)

Codifies permissive TypeScript migration guardrails and adds explicit
timing/rules for when rename-only conversion ends and type hardening
begins.

## Changes in this PR
- adds permissive strategy guidance in dev docs
(dev-docs/TYPE_STRATEGY.md)
- adds compile-only type compatibility checks (tsconfig.type-tests.json
and test/types/permissive_types.ts)
- wires typescript:compat into the typescript pipeline in package.json
- updates dev-docs/TS_MIGRATION_EXECUTION_BOARD.md with:
  - Type-Integration Policy by phase (TSM-00..TSM-91)
  - required hardening checks for TSM-06+
  - deferred typing PR requirements
  - catch-up schedule for hardening already completed foundation layers

## Testing
- npm run typescript

## Stack Context
Depends on PR #558.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants