Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added button with editable MIDI feedback values #31

Merged
merged 19 commits into from
May 25, 2020

Conversation

johannesfelber
Copy link
Contributor

This version adds a block called LaunchpadButton to General -> Controls.
This button is an extension of the normal button, which allows defining custom low and high values for MIDI feedback in the block settings. Those settings are useful for usage with Novation Launchpads, since button colors are represented by midi feedback values.

@luminosuslight luminosuslight self-requested a review May 25, 2020 08:54
Copy link
Collaborator

@luminosuslight luminosuslight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you very much for contributing! I guess this could help many users, although unfortunately I don't have the time at the moment to create a new release containing this change. Maybe I can find someone to maintain the releases.

@luminosuslight luminosuslight merged commit 7d67dc2 into ETCLabs:master May 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants