Adding basic impact diagnostics - #4427
Conversation
LisaBock
left a comment
There was a problem hiding this comment.
Thanks @lauracasp for this great diagnostics! It looks already quite good to me.
My comments are:
- I think, it would be helpful to include the used threshold in the output filename. Then it would be possible to collect all output files in the end in one directory.
- There are a lot empty files in the recipe. You can delete some of them.
- Other comments are below.
|
Thank you for the review and the suggestions! These should be implemented now, except for the .zenodo.json file, I will do that tomorrow. |
|
Thanks @lauracasp for all the changes! Yes, I agree the folder structure is good as it is. There are two more open comments regarding the files |
|
@LisaBock thanks! Both of the comments should also be resolved now. |
LisaBock
left a comment
There was a problem hiding this comment.
Thanks @lauracasp ! Looks fine now to me!
Description
Addition of basic impact diagnostics as listed in Table 1 of Elling et al 2026
! NOTE: In order to use the ORAS5 datasets on levante, the following configuration must be added to the .config/esmvaltool/data-hpc-dkrz.yml file in the native6 section:
oras5:
type: esmvalcore.io.local.LocalDataSource
rootpath: /work/bd1083/b382555/extraobsraw
dirname_template: "Tier{tier}/{dataset}/single_level" #{version}/{frequency}/{short_name}"
filename_template: "{raw_name}_*.nc"
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
New or updated recipe/diagnostic
To help with the number of pull requests: