Skip to content

Adding basic impact diagnostics - #4427

Open
lauracasp wants to merge 40 commits into
mainfrom
impact_diagnostics
Open

Adding basic impact diagnostics#4427
lauracasp wants to merge 40 commits into
mainfrom
impact_diagnostics

Conversation

@lauracasp

@lauracasp lauracasp commented May 7, 2026

Copy link
Copy Markdown

Description

Addition of basic impact diagnostics as listed in Table 1 of Elling et al 2026

! NOTE: In order to use the ORAS5 datasets on levante, the following configuration must be added to the .config/esmvaltool/data-hpc-dkrz.yml file in the native6 section:

oras5:
type: esmvalcore.io.local.LocalDataSource
rootpath: /work/bd1083/b382555/extraobsraw
dirname_template: "Tier{tier}/{dataset}/single_level" #{version}/{frequency}/{short_name}"
filename_template: "{raw_name}_*.nc"

  • Closes #issue_number
  • Link to documentation:

Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

New or updated recipe/diagnostic


To help with the number of pull requests:

@CLAassistant

CLAassistant commented May 20, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@lauracasp
lauracasp marked this pull request as ready for review August 7, 2026 13:04
@lauracasp
lauracasp requested review from LisaBock and schlunma August 7, 2026 13:04
@LisaBock LisaBock added in scientific review diagnostic requires new ESMValCore release A new release of ESMValCore is needed to solve this issue/merge this pull request.. labels Aug 10, 2026

@LisaBock LisaBock left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lauracasp for this great diagnostics! It looks already quite good to me.

My comments are:

  • I think, it would be helpful to include the used threshold in the output filename. Then it would be possible to collect all output files in the end in one directory.
  • There are a lot empty files in the recipe. You can delete some of them.
  • Other comments are below.

Comment thread esmvaltool/recipes/climatic_impact-drivers/recipe_impacts_map.yml Outdated
Comment thread esmvaltool/recipes/climatic_impact-drivers/recipe_impacts_map.yml Outdated
Comment thread esmvaltool/recipes/cmorizers/recipe_daily_era5.yml
Comment thread .zenodo.json
Comment thread esmvaltool/recipes/climatic_impact-drivers/recipe_impacts_map.yml Outdated
Comment thread esmvaltool/recipes/climatic_impact-drivers/recipe_impacts_map.yml Outdated
Comment thread esmvaltool/recipes/climatic_impact-drivers/recipe_impacts_timeseries.yml Outdated
Comment thread esmvaltool/diag_scripts/climatic_impact-drivers/multi_datasets_with_threshold.py Outdated
Comment thread doc/sphinx/source/recipes/recipe_climatic_impact-drivers.rst Outdated
Comment thread esmvaltool/diag_scripts/monitor/multi_datasets.py Outdated
@lauracasp

lauracasp commented Aug 13, 2026

Copy link
Copy Markdown
Author

Thank you for the review and the suggestions! These should be implemented now, except for the .zenodo.json file, I will do that tomorrow.
About the filenames: I changed the default filenames to include the threshold, but kept the folder structure as it is for now. Would you recommend to change the folder structure also? Moreover, would be great if you could also take a quick look at the other changes if they resolve the issues sufficiently.

@LisaBock

Copy link
Copy Markdown
Member

Thanks @lauracasp for all the changes!

Yes, I agree the folder structure is good as it is.

There are two more open comments regarding the files .zenodo.json and recipe_daily_era5.yml.

@lauracasp

Copy link
Copy Markdown
Author

@LisaBock thanks! Both of the comments should also be resolved now.

@LisaBock LisaBock left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lauracasp ! Looks fine now to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved by scientific reviewer diagnostic requires new ESMValCore release A new release of ESMValCore is needed to solve this issue/merge this pull request..

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants