Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final sanity check and reorganisation of RTW #3707

Merged
merged 13 commits into from
Jul 2, 2024

Conversation

ehogan
Copy link
Contributor

@ehogan ehogan commented Jul 1, 2024

Description


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number of pull requests:

@ehogan ehogan linked an issue Jul 1, 2024 that may be closed by this pull request
6 tasks
@ehogan ehogan self-assigned this Jul 1, 2024
@ehogan ehogan added the Recipe Test Workflow (RTW) Items relevant to the Recipe Test Workflow label Jul 1, 2024
@ehogan ehogan marked this pull request as ready for review July 1, 2024 16:59
Copy link
Contributor

@alistairsellar alistairsellar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff! I'm happy with all of this.

I've made one suggestion (in two places) which you are free to ignore. PR approved irrespective of your choice on that.

``${HOME}/cylc-run/recipe_test_workflow/run1/share/cycle/<cycle>``
directory to your site-specific KGO directory, as detailed by the
``recipe_<recipe>_<date>_<time>/``) from the
``${HOME}/cylc-run/recipe_test_workflow/run1/share/cycle/<cycle>/``
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
``${HOME}/cylc-run/recipe_test_workflow/run1/share/cycle/<cycle>/``
``${HOME}/cylc-run/recipe_test_workflow/runN/share/cycle/<cycle>/``

Use runN, which links to latest run, just in case the user makes multiple attempts and doesn't cylc clean?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alistairsellar! Done in ea42577 😊

``KGO_ROOT_PATH`` option in the site-specific ``.conf`` file in the
``esmvaltool/utils/recipe_test_workflow/recipe_test_workflow/opt/``
directory::
``esmvaltool/utils/recipe_test_workflow/opt/`` directory::

cp -r ${HOME}/cylc-run/recipe_test_workflow/run1/share/cycle/<cycle>/recipe_<recipe>_<date>_<time> <KGO_ROOT_PATH>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
cp -r ${HOME}/cylc-run/recipe_test_workflow/run1/share/cycle/<cycle>/recipe_<recipe>_<date>_<time> <KGO_ROOT_PATH>
cp -r ${HOME}/cylc-run/recipe_test_workflow/runN/share/cycle/<cycle>/recipe_<recipe>_<date>_<time> <KGO_ROOT_PATH>

If you agree with the above runN suggestion, it should be updated here also.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alistairsellar! Done in ea42577 😊

@ehogan ehogan merged commit f976b8c into recipe_test_workflow_prototype Jul 2, 2024
8 checks passed
@ehogan ehogan deleted the 3685_final_check_for_RTW branch July 2, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Recipe Test Workflow (RTW) Items relevant to the Recipe Test Workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Final sanity check and reorganisation of RTW
2 participants