-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Final sanity check and reorganisation of RTW #3707
Final sanity check and reorganisation of RTW #3707
Conversation
…pdated automatically when I ran cffconvert)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff! I'm happy with all of this.
I've made one suggestion (in two places) which you are free to ignore. PR approved irrespective of your choice on that.
``${HOME}/cylc-run/recipe_test_workflow/run1/share/cycle/<cycle>`` | ||
directory to your site-specific KGO directory, as detailed by the | ||
``recipe_<recipe>_<date>_<time>/``) from the | ||
``${HOME}/cylc-run/recipe_test_workflow/run1/share/cycle/<cycle>/`` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
``${HOME}/cylc-run/recipe_test_workflow/run1/share/cycle/<cycle>/`` | |
``${HOME}/cylc-run/recipe_test_workflow/runN/share/cycle/<cycle>/`` |
Use runN
, which links to latest run, just in case the user makes multiple attempts and doesn't cylc clean
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @alistairsellar! Done in ea42577 😊
``KGO_ROOT_PATH`` option in the site-specific ``.conf`` file in the | ||
``esmvaltool/utils/recipe_test_workflow/recipe_test_workflow/opt/`` | ||
directory:: | ||
``esmvaltool/utils/recipe_test_workflow/opt/`` directory:: | ||
|
||
cp -r ${HOME}/cylc-run/recipe_test_workflow/run1/share/cycle/<cycle>/recipe_<recipe>_<date>_<time> <KGO_ROOT_PATH> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cp -r ${HOME}/cylc-run/recipe_test_workflow/run1/share/cycle/<cycle>/recipe_<recipe>_<date>_<time> <KGO_ROOT_PATH> | |
cp -r ${HOME}/cylc-run/recipe_test_workflow/runN/share/cycle/<cycle>/recipe_<recipe>_<date>_<time> <KGO_ROOT_PATH> |
If you agree with the above runN
suggestion, it should be updated here also.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @alistairsellar! Done in ea42577 😊
…e how to add a recipe documentation
Description
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number of pull requests: