Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge the RTW documentation with the ESMValTool documentation #3684

Merged
merged 5 commits into from
Jun 26, 2024

Conversation

ehogan
Copy link
Contributor

@ehogan ehogan commented Jun 25, 2024

Description


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number of pull requests:

@ehogan ehogan changed the base branch from main to recipe_test_workflow_prototype June 25, 2024 16:35
@ehogan ehogan self-assigned this Jun 25, 2024
@ehogan ehogan added the Recipe Test Workflow (RTW) Items relevant to the Recipe Test Workflow label Jun 25, 2024
@ehogan ehogan marked this pull request as ready for review June 25, 2024 18:21
Copy link
Contributor

@alistairsellar alistairsellar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff @ehogan! Exciting to be completing the prototype!

Just two suggested changes:

  • one in the comment below (utils structure) and
  • can/should we move the actual workflow dir esmvaltool/utils/recipe_test_workflow/recipe_test_workflow up one level, now that esmvaltool/utils/recipe_test_workflow doesn't contain the doc dir?

@ehogan
Copy link
Contributor Author

ehogan commented Jun 26, 2024

Great stuff @ehogan! Exciting to be completing the prototype!

🥳

Just two suggested changes:

  • one in the comment below (utils structure) and

I'll address this in the comment 👍

  • can/should we move the actual workflow dir esmvaltool/utils/recipe_test_workflow/recipe_test_workflow up one level, now that esmvaltool/utils/recipe_test_workflow doesn't contain the doc dir?

Yes, I was planning to do this via a separate PR after this (which will include a final sanity check of the documentation to ensure the documentation uses the correct paths etc.) 😊

@alistairsellar
Copy link
Contributor

Yes, I was planning to do this via a separate PR after this (which will include a final sanity check of the documentation to ensure the documentation uses the correct paths etc.) 😊

Sounds good - thanks!

@ehogan ehogan merged commit 49a4909 into recipe_test_workflow_prototype Jun 26, 2024
8 checks passed
@ehogan ehogan deleted the 3253_merge_RTW_docs branch June 26, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Recipe Test Workflow (RTW) Items relevant to the Recipe Test Workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge the RTW documentation with the ESMValTool documentation
2 participants