Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding HadEX3 CMORizer #3636

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Adding HadEX3 CMORizer #3636

wants to merge 6 commits into from
+266 −0

Conversation

malininae
Copy link
Contributor

This is a PR to add HadEX3 CMORizer needed for IPCC AR6 WGI Chapter 3, Cross Chapter Box 3.2. The issue is #3617, custom tables are in the issue 2441 in ESMValCore.

@malininae malininae added observations requires new ESMValCore release A new release of ESMValCore is needed to solve this issue/merge this pull request.. IPCC labels May 29, 2024
@malininae malininae added this to the v2.12.0 milestone Feb 5, 2025
@malininae malininae marked this pull request as ready for review February 5, 2025 20:57
@malininae malininae requested a review from a team as a code owner February 5, 2025 20:57
@malininae malininae requested a review from LisaBock February 5, 2025 20:57
@malininae
Copy link
Contributor Author

Hi all, I'm marking this PR ready for review, but I'm afraid, I might need some help to try to figure out all the codacy fails.

First of all, the test is failing because the txx, tnn, rx1day and rx5day aren't available in the core yet, however, this PR is ready for review and hopefully will be merged in for the 2.12 release.

Second, codacy is complaining about few things that I have no control over, for example, it's complaining that I have 6 input variables in cmorization function, however, that requirement comes from the cmorization class, as far as I understand. I was looking at the other examples like HadCRUT5 and it seems to be similar. Anyway, any advice will be highly appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LisaBock LisaBock Awaiting requested review from LisaBock

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
help wanted IPCC looking for scientific reviewer looking for technical reviewer observations requires new ESMValCore release A new release of ESMValCore is needed to solve this issue/merge this pull request..
Projects
None yet
Milestone
v2.12.0
Development

Successfully merging this pull request may close these issues.
1 participant
@malininae