Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the name of the remapcon2 operator in R recipes #3611

Merged
merged 4 commits into from
May 23, 2024

Conversation

ehogan
Copy link
Contributor

@ehogan ehogan commented May 22, 2024

Description


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

New or updated recipe/diagnostic


To help with the number of pull requests:

@ehogan ehogan self-assigned this May 22, 2024
@ehogan ehogan added this to the v2.11.0 milestone May 22, 2024
@ehogan ehogan added the bug label May 22, 2024
Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks @ehogan 🍺

@bouweandela
Copy link
Member

Thanks! Could you please do the checklist?

@ehogan
Copy link
Contributor Author

ehogan commented May 23, 2024

Thanks! Could you please do the checklist?

Apologies, now done! 😊 Although, it did make me wonder whether I should add a pin to cdo (>=2.3.0) as remapscon2 will only work from v2.3.0 onwards 🤔

@bouweandela
Copy link
Member

Thanks, that's why we have the checklist ;-) Updating the pin sounds like a good idea.

@ehogan
Copy link
Contributor Author

ehogan commented May 23, 2024

Thanks, that's why we have the checklist ;-) Updating the pin sounds like a good idea.

Thanks @bouweandela! 🥳 Added in 618b6f8 👍

@valeriupredoi
Copy link
Contributor

valeriupredoi commented May 23, 2024

@ehogan cdo on PyPI is old, stuck at 1.6.0 so pinning it in setup.py will trigger an actual search of the index, so it fails coz it can't find a requested version to satisfy the pin, I'd not pin it in setup.py, and just leave it pinned in the conda env file 👍🍺

@ehogan
Copy link
Contributor Author

ehogan commented May 23, 2024

@ehogan cdo on PyPI is old, stuck at 1.6.0 so pinning it in setup.py will trigger an actual search of the index, so it fails coz it can't find a requested version to satisfy the pin, I'd not pin it in setup.py, and just leave it pinned in the conda env file 👍🍺

Thanks @valeriupredoi; I removed the pin in setup.py in b929755. I also realised I hadn't added it to environment_osx.yml, so I did that in bfe68d9 😊

@valeriupredoi
Copy link
Contributor

Many thanks @ehogan all looks good to me, @bouweandela maybe you could approve and merge when you got a minute 🍺

@bouweandela
Copy link
Member

cdo on PyPI is old, stuck at 1.6.0 so pinning it in setup.py will trigger an actual search of the index, so it fails coz it can't find a requested version to satisfy the pin, I'd not pin it in setup.py, and just leave it pinned in the conda env file

That is not quite correct. The cdo package on PyPI is on conda-forge as python-cdo. This is a Python wrapper around cdo, not cdo itself. See https://github.com/conda-forge/python-cdo-feedstock/blob/main/recipe/meta.yaml.

@bouweandela bouweandela merged commit ead073d into main May 23, 2024
8 checks passed
@bouweandela bouweandela deleted the 3610_update_remapcon2_operator branch May 23, 2024 11:19
@ehogan ehogan changed the title Update the name of the remapcon2 operator in R recipes Update the name of the remapcon2 operator in R recipes Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the name of the remapcon2 operator in R recipes
3 participants