-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the name of the remapcon2 operator in R recipes #3611
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks @ehogan 🍺
Thanks! Could you please do the checklist? |
Apologies, now done! 😊 Although, it did make me wonder whether I should add a pin to cdo ( |
Thanks, that's why we have the checklist ;-) Updating the pin sounds like a good idea. |
Thanks @bouweandela! 🥳 Added in 618b6f8 👍 |
@ehogan cdo on PyPI is old, stuck at 1.6.0 so pinning it in setup.py will trigger an actual search of the index, so it fails coz it can't find a requested version to satisfy the pin, I'd not pin it in setup.py, and just leave it pinned in the conda env file 👍🍺 |
Thanks @valeriupredoi; I removed the pin in |
Many thanks @ehogan all looks good to me, @bouweandela maybe you could approve and merge when you got a minute 🍺 |
That is not quite correct. The cdo package on PyPI is on conda-forge as python-cdo. This is a Python wrapper around cdo, not cdo itself. See https://github.com/conda-forge/python-cdo-feedstock/blob/main/recipe/meta.yaml. |
Description
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
New or updated recipe/diagnostic
To help with the number of pull requests: