Store RTW files in share directory in installed workflow

[mo-gill]

Description

This PR should successfully store RTW files in the share directory in installed workflows

• Closes Store RTW files in share directory in installed workflow #3434
• Link to documentation:

---

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

• 🛠 This pull request has a descriptive title
• 🛠 Code is written according to the code quality guidelines

• 🛠 The list of authors is up to date
• 🛠 Any changed dependencies have been added or removed correctly
• 🛠 All checks below this pull request were successful

To help with the number of pull requests:

• 🙏 We kindly ask you to review two other open pull requests in this repository

[ehogan]

Nice work @mo-gill, thank you! 🎉

Once you have responded to my review comments, would you ask Alistair to test the changes to ensure it behaves the way he expects, please? (It looks ok to me, but it would be good to get confirmation from Alistair also) 👍

[ehogan]

Thanks @mo-gill! 🥳

[alistairsellar]

Great work @mo-gill !

This does exactly what I was expecting. Example work task for me:

$ export CYLC_VERSION=8
$ cylc vip -O metoffice
# Then let it run / fail on first cycle. I might then change a file in workflow source, although not required for this demo
$ cylc validate-reinstall -O metoffice recipe_test_workflow
<snip>
send rose-suite.conf

NOTE: Files created by Rose file installation will show as deleted.
      They will be re-created during the reinstall process.

TIP: You can "exclude" files/dirs to prevent Cylc from installing or overwriting
     them by adding them to the .cylcignore file. See cylc reinstall --help.

Reinstall would make the above changes.
Continue [y/n]: y
REINSTALLED recipe_test_workflow/run12 from /net/data/users/hadtq/esmvaltool/operate_rtw/ESMValTool/esmvaltool/utils/recipe_test_workflow/recipe_test_workflow
Successfully reinstalled.
<snip>
$ cylc gui
# Go to GUI and trigger individual tasks

Without this branch, the validate-reinstall step deletes essential files, and therefore the triggered tasks fail in the final step. With this branch I was able to successfully trigger tasks and they gave the same results as on the first (=clean) run.