Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run a periodic esmvalbot test via automated PR #3465

Merged
merged 27 commits into from
Nov 29, 2024
Merged

Conversation

valeriupredoi
Copy link
Contributor

@valeriupredoi valeriupredoi commented Dec 12, 2023

Description

This PR adds a Github Action that sets up an automated PR (via an empty commit, so no actual files changed, even if that PR gets merged by accident) where Esmvalbot gets invoked to run an example recipe (recipe_python.yml, but that can change) via comment from the GH bot, to test our bot periodically. This is how the auto PR looks like #3468 (don't mind the failed codacy, the auto PR will target main after this PR gets merged). The only hitch at the moment is to allow github-actions[bot] to invoke Esmvalbot, easily done if peeps are OK with it - the rest is as if it was a use ie open PR, invoking Esmvalbot via comment, labels etc that reminds @valeriupredoi @bouweandela and @schlunma to run a Esmvalbot test, see #3804 - previously the github-actions bot was invoking ESMValBot but that's not possible unless the GH bot is added as a user in esmvalbot's books - and that's a bit contentious and probably not safe - now all it does it pings us to run a test, every 10 days or so, but that can change to every month or so.


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

@bouweandela
Copy link
Member

The only hitch at the moment is to allow github-actions[bot] to invoke Esmvalbot, easily done if peeps are OK with it

I'm not sure if we would be allowed to do that from a security point of view. I also do not feel qualified to make a judgment on that. Is this an important topic to you? Maybe we could discuss it with the providers of the machine that the bot runs on.

@mo-gill
Copy link
Contributor

mo-gill commented May 2, 2024

Hi, we are currently working on the ESMValTool release for v2.11.0. We're wondering if you'd be able to complete this PR by the end of next week (Friday 10th May).

Otherwise, please let us know, and we'll move it into the next milestone for you 🙂

@valeriupredoi
Copy link
Contributor Author

am moving this to M2.12 since we're still not decided if the bot can have that much powah 🤖

@valeriupredoi valeriupredoi removed this from the v2.11.0 milestone May 3, 2024
@valeriupredoi
Copy link
Contributor Author

The only hitch at the moment is to allow github-actions[bot] to invoke Esmvalbot, easily done if peeps are OK with it

I'm not sure if we would be allowed to do that from a security point of view. I also do not feel qualified to make a judgment on that. Is this an important topic to you? Maybe we could discuss it with the providers of the machine that the bot runs on.

converted this to a simple "reminder to check the bot" PR @bouweandela - a lot safer and less fiddly 🍺

@bouweandela bouweandela merged commit 5453d58 into main Nov 29, 2024
10 checks passed
@bouweandela bouweandela deleted the cron_esmvalbot_test branch November 29, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants