Removed fx_variables in recipe_mpqb_xch4 and recipe_lauer22jclim_fig8
#3117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 tasks
remi-kazeroni
changed the title
fx_variables in recipe_mpqb_xch4 and recipe_lauer22jclim_fig8
remi-kazeroni
approved these changes
Mar 20, 2023
There was a problem hiding this comment.
Thanks @axel-lauer! Looks good to me, recipes run successfully for me as well. @valeriupredoi: quick look and merge, please? 🍺
valeriupredoi
approved these changes
Mar 20, 2023
There was a problem hiding this comment.
many thanks to @axel-lauer for the PR and changes and to @remi-kazeroni for testing and reviewing 🍺 x2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adapts recipe_mpqb_xch4.yml and recipe_lauer22jclim_fig8 to comply with the new requirements (remove fx_variables) introduced in ESMValCore PR ESMValGroup/ESMValCore#1609.
See also issue #3056.
I tested the two recipes successfully. The output looks as expected.
Checklist
New or updated recipe/diagnostic