Skip to content

explicitly export LC_ALL for sphinx builds #2708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

valeriupredoi
Copy link
Contributor

@valeriupredoi valeriupredoi commented Apr 15, 2025

Description

Investigations done in
#2706
our builds suffering from this issue sphinx-doc/sphinx#11739 - no idea why it's reared its head only now, and why it's not manifesting itself in ESMValTool

Closes #2705


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@valeriupredoi valeriupredoi added documentation Improvements or additions to documentation testing labels Apr 15, 2025
Copy link

codecov bot commented Apr 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.10%. Comparing base (7a1ffd4) to head (c31ac4c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2708   +/-   ##
=======================================
  Coverage   95.10%   95.10%           
=======================================
  Files         257      257           
  Lines       15021    15021           
=======================================
  Hits        14286    14286           
  Misses        735      735           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@valeriupredoi
Copy link
Contributor Author

valeriupredoi commented Apr 15, 2025

this is unfortunately not the solution

setting it to LC_ALL=C looks to be doing the part

@valeriupredoi valeriupredoi deleted the force_setlocale_build_docs branch April 15, 2025 13:25
@valeriupredoi valeriupredoi restored the force_setlocale_build_docs branch April 15, 2025 16:14
@valeriupredoi valeriupredoi reopened this Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build on readthedocs failing
1 participant