-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue where data was not loaded and saved #1963
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1963 +/- ##
==========================================
+ Coverage 92.66% 92.79% +0.12%
==========================================
Files 236 236
Lines 12437 12437
==========================================
+ Hits 11525 11541 +16
+ Misses 912 896 -16
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@remi-kazeroni This works, but I'd like to add another test. I'm not working today, so if you're in a hurry you can merge this if it solves your issue and then I'll open another pull request next week to add the extra test. |
@bouweandela thanks for providing the fix. It's totally fine for me to wait that you add the test before this. I'll do a bit of recipe testing early next week. My plan would be to release rc2 towards the end of next week. Would be great to have this PR in there 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @bouweandela! This looks good to me. I've several recipes including the 2 that were failing prior to this PR and all works fine now 👍
@ESMValGroup/technical-lead-development-team could someone have a final look and merge, please?
Awesome, thanks @bouweandela and @remi-kazeroni 🚀 |
Co-authored-by: Rémi Kazeroni <[email protected]>
Description
This fixes an issue where data was not loaded and saved if no preprocessing was needed for that particular dataset, but it was part of a variable that also had other datasets that did need preprocessing. For example: a preprocessor
with datasets
CanESM2
and at least one other dataset.This bug was introduced in #1609 and was not part of a release.
Closes #1962
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: