-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a feature to read facets from filenames #1943
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1943 +/- ##
==========================================
+ Coverage 92.18% 92.20% +0.01%
==========================================
Files 234 234
Lines 12213 12241 +28
==========================================
+ Hits 11259 11287 +28
Misses 954 954 ☔ View full report in Codecov by Sentry. |
Bumping this to the next milestone, since the required work in ESMValTool has not been done yet. |
I looked into adding the fix for
to the loop over keys and separators before this line: That way a facet followed by a hyphen separator must have already been extracted, which should take care of the cordex paths. If the facet is not already extracted, the extraction will simply stop. Of course, with this code there will be a limit to which facets can be extracted from a cordex filename alone, would that be an acceptable limitation? |
Dropping this for v2.10 for the same reason. |
52d3951
to
ee4e2db
Compare
Description
Until now, facets can only be read from directory names. This adds a feature to read facets from filenames. It offers limited support for the combination with glob patterns in the filename template.
Only merge this after ESMValGroup/ESMValTool#3051 is resolved, to avoid reading the wrong version numbers from the filenames for the OBS and OBS6 project.-> DoneBefore you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: