-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add event UUID to event schema #40
base: main
Are you sure you want to change the base?
Conversation
I see that this UUID is in the Metadata section, which I do agree it belongs in; however I think that this field will not get into the STAC catalog? If this is the case can it still be used for end to end error detection, or is it the case that as we want to use this for error analysis and errors will not get into the STAC catalog that this is OK? TL;DR: I think this is the right place but do we also want the UUID in the STAC catalog? |
I don't think it needs to be in the STAC record as it will be in the materialised view. If it were in the STAC record would this be a list of all events associated with the record or just the last event? |
I agree that it probably doesn't need to be in the catalog since the consumer responsible for putting the data into the catalog will have access to it and should be able add it to any error message generated. At the risk of bike shedding one of the hardest problems in software, I would suggest giving the field a somewhat more descriptive name. Perhaps |
Just to note I've included the changes to the auth section that were suggested in the ad-hoc meeting. |
Note on separate event and request ids the request id will be the same thought the life of the request the event id will change when moving to a new stream/queue for example moving to the error queue. |
Is the idea of removing |
Yes, it could be looked up by |
So are we not doing any auth checks of our own? Or are we doing the auth checks AND system logging? |
We'll do the auth checks, the only change is that we are recording the reason for +/-authz to system log rather than the event payload. |
@rhysrevans3 The PR adds
Fields in the How does the authorization flow look like with EGI Check-in? Does EGI Check-in use |
@lukaszlacinski I added user_id to replace the personal information as I thought this would be better for GDPR. The key was just chosen at random so we could switch to using |
@rhysrevans3 |
I've removed |
No description provided.