Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase 1 of rk_stratiform CCPPization; CCPPize cldfrc #219

Open
wants to merge 24 commits into
base: development
Choose a base branch
from

Conversation

jimmielin
Copy link
Member

@jimmielin jimmielin commented Mar 10, 2025

Originator(s): @jimmielin

Description (include issue title and the keyword ['closes', 'fixes', 'resolves'] and issue number):

  • Partial CCPPization work of rk_stratiform (CAM4 microphysics and macrophysics) - Convert rk_stratiform_tend (CAM4) to CCPP #190, including:
  • Cloud sedimentation cloud_particle_sedimentation (from src/physics/cam/pkg_cld_sediment.F90)
  • Prognostic cloud water prognostic_cloud_water (pcond from src/physics/cam/cldwat.F90)
  • Most interstitial code in rk_stratiform_tend moved to rk_stratiform_* interstitial schemes
  • CCPPization of compute_cloud_fraction (cldfrc in src/physics/cam/cloud_fraction.F90); separating out shallowcu and deepcu and concld computation to convective_cloud_cover CCPPized scheme. This is used in CAM4 and CAM5
  • Dechunkize and move to to_be_ccppized/cloud_optical_properties.F90 several cloud optical property functions to src/physics/cam/pkg_cldoptics.F90: this is used in several cloud diagnostics in CAM.

This code is not fully ready for use in SIMA in the current state. This is a first stage cleanup to move as much of rk_stratiform_tend code to atmospheric_physics as possible, before completing CCPPization. Thus the following changes are not in the scope of this PR (although reasonable effort has been made to complete these as much as possible):

  • Completing metadata for use in CAM-SIMA
  • Finalize standard names
  • Create diagnostic schemes that correspond to existing diagnostics provided in CAM4
  • Create test cases for FPHYStest with rasch_kristjansson SDF

Companion PR in ESCOMP/CAM: ESCOMP/CAM#1271

List all namelist files that were added or changed:

A       schemes/cloud_fraction/compute_cloud_fraction_namelist.xml
A       schemes/cloud_fraction/convective_cloud_cover_namelist.xml
A       schemes/rasch_kristjansson/cloud_particle_sedimentation_namelist.xml
A       schemes/rasch_kristjansson/prognostic_cloud_water_namelist.xml

List all files eliminated and why: N/A

List all files added and what they do:

A       schemes/cloud_fraction/compute_cloud_fraction.F90
A       schemes/cloud_fraction/compute_cloud_fraction.meta
A       schemes/cloud_fraction/convective_cloud_cover.F90
A       schemes/cloud_fraction/convective_cloud_cover.meta
 - CCPPize cldfrc

A       schemes/rasch_kristjansson/cloud_particle_sedimentation.F90
A       schemes/rasch_kristjansson/cloud_particle_sedimentation.meta
 - CCPPize former `pkg_cld_sediment`

A       schemes/rasch_kristjansson/prognostic_cloud_water.F90
A       schemes/rasch_kristjansson/prognostic_cloud_water.meta
 - CCPPize former `cldwat`

A       schemes/rasch_kristjansson/rk_stratiform.F90
A       schemes/rasch_kristjansson/rk_stratiform.meta
 - Move most interstitial code in rk_stratiform_tend to individual CCPPized schemes

A       test/test_suites/suite_rasch_kristjansson.xml
 - Draft rk_stratiform_tend SDF

A       to_be_ccppized/cloud_optical_properties.F90
 - Dechunkized and moved from `pkg_cldoptics.F90`

List all existing files that have been modified, and describe the changes:
(Helpful git command: git diff --name-status development...<your_branch_name>)
N/A

List all automated tests that failed, as well as an explanation for why they weren't fixed: N/A

Is this an answer-changing PR? If so, is it a new physics package, algorithm change, tuning change, etc?

B4B for CAM regression tests:
These changes are expected to be bit-for-bit for current CAM. If all CAM4 diagnostics are enabled, there are two history fields (HPROGCLD and HREPART) that have roundoff level differences in the order of 1e-17 ~ 1e-16 due to rearranging of terms to compute diagnostics.

Not fully complete for use in SIMA in current state

If yes to the above question, describe how this code was validated with the new/modified features:

CAM regression tests expected to all pass. Verification will be made again before this PR is pushed to development

@jimmielin jimmielin self-assigned this Mar 10, 2025
@jimmielin jimmielin changed the title Batch 1 of rk_stratiform CCPPization; CCPPize cldfrc Phase 1 of rk_stratiform CCPPization; CCPPize cldfrc Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

1 participant