-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Phase 1 of rk_stratiform CCPPization; CCPPize cldfrc #219
Open
jimmielin
wants to merge
24
commits into
ESCOMP:development
Choose a base branch
from
jimmielin:hplin/rk_stratiform
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- prognostic_cloud_water sketch out
Reformat cloud_optical_properties Stub rk_stratiform sub-schemes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originator(s): @jimmielin
Description (include issue title and the keyword ['closes', 'fixes', 'resolves'] and issue number):
cloud_particle_sedimentation
(fromsrc/physics/cam/pkg_cld_sediment.F90
)prognostic_cloud_water
(pcond
fromsrc/physics/cam/cldwat.F90
)rk_stratiform_tend
moved tork_stratiform_*
interstitial schemescompute_cloud_fraction
(cldfrc
insrc/physics/cam/cloud_fraction.F90
); separating outshallowcu
anddeepcu
andconcld
computation toconvective_cloud_cover
CCPPized scheme. This is used in CAM4 and CAM5to_be_ccppized/cloud_optical_properties.F90
several cloud optical property functions tosrc/physics/cam/pkg_cldoptics.F90
: this is used in several cloud diagnostics in CAM.This code is not fully ready for use in SIMA in the current state. This is a first stage cleanup to move as much of rk_stratiform_tend code to atmospheric_physics as possible, before completing CCPPization. Thus the following changes are not in the scope of this PR (although reasonable effort has been made to complete these as much as possible):
Companion PR in ESCOMP/CAM: ESCOMP/CAM#1271
List all namelist files that were added or changed:
List all files eliminated and why: N/A
List all files added and what they do:
List all existing files that have been modified, and describe the changes:
(Helpful git command:
git diff --name-status development...<your_branch_name>
)N/A
List all automated tests that failed, as well as an explanation for why they weren't fixed: N/A
Is this an answer-changing PR? If so, is it a new physics package, algorithm change, tuning change, etc?
B4B for CAM regression tests:
These changes are expected to be bit-for-bit for current CAM. If all CAM4 diagnostics are enabled, there are two history fields (
HPROGCLD
andHREPART
) that have roundoff level differences in the order of 1e-17 ~ 1e-16 due to rearranging of terms to compute diagnostics.Not fully complete for use in SIMA in current state
If yes to the above question, describe how this code was validated with the new/modified features:
CAM regression tests expected to all pass. Verification will be made again before this PR is pushed to
development