Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Complete Zhang McFarlane conversion to CCPP #186
Complete Zhang McFarlane conversion to CCPP #186
Changes from 2 commits
c6f2699c6ddcb42e967103c6447a2abb58d2d7b5895b89cb52208d4570c04502252688c8076de102cd40755a07be8dc85f6cf8164c79069600c566dd9d0e5d721142e34e609baba6bee094d677fd27d14592fe83bff9925752c55093a1dbff8ce60bd17b4ed307d8bc67927f1e10f811cb796e95b34c32f0f9ac63d44c2b3349c8f73d6a7dd1196652380fa65766e67c3de84652e951ea6e3d345789a10a7f33e59d030254eaff0d582a284508f8dfbe92b7698347673cf1473c5b16f71ef935827e410b7d1ab92File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we need to add another set of
check_energycalls after the ZM block here:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @nusbaume, also wanted to add that before running the ZM scheme, the following should be called to zero the inputs to
check_energy_chng:Some inputs need to be provided to
check_energy_chngto actually check the energy changes match the boundary fluxes.Based on
physpkg.F90calls to check_energy_chng afterconvect_deep_tend:the following inputs need to be provided (as an output from the ZM scheme):
scheme_name="convect_deep"net_liquid_and_lwe_ice_fluxes_through_top_and_bottom_of_atmosphere_column("flx_cnd" in check_energy_chng) =prec_dp(:ncol) + rliq(:ncol)net_lwe_ice_fluxes_through_top_and_bottom_of_atmosphere_column("flx_ice" in check_energy_chng; I don't like how the above code is recyclingsnow_dpthere simply for callingcheck_energy_cam_chng) =snow_dp(:ncol) + rice(:ncol)I realized I have to make the same changes for the shallow convection. Here is how I added these fluxes for my scheme: jimmielin@8c9b103
It looks like
snow_dpcomes fromzm_conv_evap, so that needs to be provided in the interstitial that renames general to deep. But in the case of ZM,ricehas to be added on top of it. Maybe passnet_lwe_ice_fluxes_through_top_and_bottom_of_atmosphere_columninto both the scheme that computesricethen addsnow_dpon top of it in the interstitial.Or if this is too much work feel free to open an issue? I can add this since I made
check_energy_chngso I am the person to blame 😃There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jimmielin - can we open this as a new issue? I have converted ZM, and we can make convect_deep with its additional features a new PR? I'm literally on my last edits and I want to avoid feature creep (and missing deadlines)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cacraigucar agreed, I am happy to defer this to the future - I can work on this as an example of how
check_energy_chngis called as I didn't have a good example to work with when I converted it.Added issue #192
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all sounds like a good plan to me! I'm keeping this open so we can find it if need be, but feel free to consider it "resolved" for this PR. Thanks!
This file was deleted.