Repository navigation
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## latest #3719 +/- ##
==========================================
+ Coverage 75.97% 76.05% +0.08%
==========================================
Files 461 460 -1
Lines 114795 114697 -98
Branches 17990 17969 -21
==========================================
+ Hits 87215 87234 +19
+ Misses 27294 27177 -117
Partials 286 286 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
highs/pdlp/cupdlp/cupdlp_cs.candcupdlp_cs.hare adapted from Tim Davis's CSparse, which is LGPL-2.1-or-later. Upstream cuPDLP-C now labels them as such. Downstream distributions that need permissively licensed bundled code, such as SciPy, can't ship them.They had only one use:
csc2csr(and the unusedcsr2csc) incupdlp_utils.c. These transposed the constraint matrix so that cuPDLP-C holds both a CSC and a CSR copy.Changes:
CupdlpWrapper.cpp: the newcsr_alloc_from_cscbuilds the CSR copy from the scaled CSC matrix with HiGHS's ownHighsSparseMatrix::ensureRowwise, then passes it tocsr_alloc_matrixas a CSR source.data_allocnow returnsRETCODE_FAILEDfor any input format other than CSC. The wrapper only ever passes CSC.cupdlp_utils.c/.h: deletescsc2csr,csr2cscand the CSR↔CSC cases incsr_alloc_matrix/csc_alloc_matrix.csr_copynow copies withCUPDLP_COPY_VECand creates the cuSPARSE CSR descriptor, matchingcsc_copy.csc2csrused to do both, so GPU builds keep their device CSR matrix. As a resultcsr_copyreturnscupdlp_intinstead ofvoid.cupdlp_cs.c/.hand removes them fromcupdlp.h,cmake/sources.cmake, the CUDA source list inhighs/CMakeLists.txt,highs/meson.buildandcupdlp/Diff. Bazel picks up*.cby glob, so it needs no change.cupdlp/README.md: notes why the files were removed.These are internal cuPDLP-C symbols, so the HiGHS API and the language bindings are unchanged. The installed internal header
include/highs/pdlp/cupdlp/cupdlp_cs.hno longer exists.Checklist
latestbranchRelated issue
Closes #3712