Repository navigation
Conversation
HiPDLP used pdlp_optimality_tolerance for its primal, dual and gap termination tests, so primal_feasibility_tolerance and dual_feasibility_tolerance had no effect on it, although HiGHS's KKT check of the solution uses them. As for cuPDLP-C, use them for the primal and dual tests, and pdlp_optimality_tolerance for the gap; kkt_tolerance still overrides all three. No change with default options, since all three default to 1e-7. Add a test that tightening the feasibility tolerances makes HiPDLP and cuPDLP-C iterate for longer.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## latest #3717 +/- ##
==========================================
+ Coverage 75.96% 75.99% +0.03%
==========================================
Files 461 461
Lines 114730 114892 +162
Branches 17977 18001 +24
==========================================
+ Hits 87155 87314 +159
- Misses 27289 27292 +3
Partials 286 286 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jajhall
approved these changes
Nov 17, 2026
Member
There was a problem hiding this comment.
It makes sense to align HiPDLP with the other LP solvers in this way. Perhaps more than with the other solvers, if folk set crazy values for these tolerances the performance of HiPDLP might be compromised, but we can add a warning and then it's on the users.
I've discussed this with @Yanyu000
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
HiPDLP used pdlp_optimality_tolerance for its primal, dual and gap termination tests, so primal_feasibility_tolerance and dual_feasibility_tolerance had no effect on it, although HiGHS's KKT check uses them. As cuPDLP-C does, it now uses them for the primal and dual tests, keeping pdlp_optimality_tolerance for the gap; kkt_tolerance still overrides all three. There's no change with default options, since all three default to 1e-7. I also added a new test hi-pdlp-feasibility-tolerances which fails without this change and passes with it.
Checklist
latestbranch