Fixed use of deprecated yamlfile argument to get_keywords()
#494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #494 +/- ##
==========================================
- Coverage 84.75% 84.71% -0.05%
==========================================
Files 30 30
Lines 4789 4789
==========================================
- Hits 4059 4057 -2
- Misses 730 732 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
francescalb
reviewed
Feb 4, 2026
tests/datadoc/test_keywords.py
Outdated
| ) | ||
| kw6 = get_keywords(kw4) | ||
| kw6.load_yaml(testdir / "input" / "custom_keywords.yaml") | ||
| assert kw4.data.theme == ["ddoc:datadoc", "ddoc:prefixes", "ddoc:process"] |
Contributor
There was a problem hiding this comment.
Suggested change
| assert kw4.data.theme == ["ddoc:datadoc", "ddoc:prefixes", "ddoc:process"] | |
| assert kw4.data.theme == ["ddoc:datadoc", "ddoc:prefixes", "ddoc:process"] | |
| ```¨ | |
| kw6? |
Contributor
Author
There was a problem hiding this comment.
Corrected, thanks
francescalb
approved these changes
Feb 4, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed use of deprecated yamlfile argument to get_keywords().
Note: The failing tests is because that we don't test deprecated functions (tests were updated to the new function). I think that this is fine.
Type of change
Checklist for the reviewer
This checklist should be used as a help for the reviewer.