This repository was archived by the owner on Apr 11, 2019. It is now read-only.
Time zone handling improvements #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion rather than make timezone errors
|
Any news on this? In my opinion, this is about a critical bug... By the way, I see that the tests fail with |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have noticed that C-BAS in some cases returns credentials with an expiration date that is missing a timezone. This is a major bug: A client can't know if the returned date is in the UTC timezone, in the server's local timezone, or in some other timezone. It also means that the date is not valid RFC3339 (since that requires a timezone at all time). So RFC3339 date parsers might fail for such dates. The jFed client (and probably others as well) will get into trouble because of missing timezones.
In my opinion, this timezone bug is very bad and need to be fixed...
This pull request tries to fix these issues. However, I'm not sure if everything I've done is 100% correct: I'm not very experienced with python and the handling of dates in python (with naive and aware dates etc) is confusing.
Also note that some of the changes are done in "src/vendor" which means they are changes in external libraries used by C-BAS.
It would be great if you could review (and test) these changes!