Skip to content

Migrate time stamp control from namelist to the meteorological driver header #413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Migrate time stamp control from namelist to the meteorological driver header #413

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
761102e
This pull request removes variable IMETAVG from the namelist, and int…
mpaiao Feb 11, 2025
d026a05
Minor bug fix to prevent CI tests to fail, and update to dataset sour…
mpaiao Feb 11, 2025
d98f708
Merge branch 'mpaiao-pr-fix-ts' into mpaiao-pr-imetavg
mpaiao Feb 11, 2025
6c0dbc9
Merge branch 'master' into mpaiao-pr-imetavg
mpaiao May 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions BRAMS/src/ed2/edcp_load_namelist.f90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ subroutine read_ednl(iunit,filename)
, imettype & ! intent(out)
, metcyc1 & ! intent(out)
, metcycf & ! intent(out)
, imetavg & ! intent(out)
, imetrad & ! intent(out)
, lapse_scheme ! ! intent(out)
use mem_polygons , only : n_poi & ! intent(out)
Expand Down Expand Up @@ -519,7 +518,6 @@ subroutine read_ednl(iunit,filename)
imettype = 1 ! BRAMS is the meteorology driver...
metcyc1 = 0000 ! BRAMS is the meteorology driver...
metcycf = 0000 ! BRAMS is the meteorology driver...
imetavg = 0 ! BRAMS is the meteorology driver...
ioptinpt = '' ! It will be used once optimization is
! implemented in ED-2.1.
unitfast = 0 ! Since BRAMS uses frqanl and frqhist in seconds, there is no
Expand Down
16 changes: 0 additions & 16 deletions ED/Template/Template/ED2IN
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1982,21 +1982,6 @@ $ED_NL
! IMETCYCF -- Last year for which meteorological driver files exist. In addition, !
! the model assumes that files exist for all years between METCYC1 and !
! METCYCF. !
! IMETAVG -- How the input radiation was originally averaged. You must tell this !
! because ED-2.1 can make a interpolation accounting for the cosine of !
! zenith angle. !
! -1. (Deprecated) I don't know, use linear interpolation. !
! 0. No average, the values are instantaneous !
! 1. Averages ending at the reference time !
! 2. Averages beginning at the reference time !
! 3. Averages centred at the reference time !
! !
! IMPORTANT: The user must obtain the correct information for each !
! meteorological driver before running the model, and set !
! this variable consistently. Inconsistent settings are !
! known to cause numerical instabilities, particularly at !
! around sunrise and sunset times. !
! !
! IMETRAD -- What should the model do with the input short wave radiation? !
! 0. (ED-2.2 default, when radiation components were measured) !
! Nothing, use it as is. !
Expand All @@ -2022,7 +2007,6 @@ $ED_NL
NL%ISHUFFLE = 0
NL%METCYC1 = mymetcyc1
NL%METCYCF = mymetcycf
NL%IMETAVG = mymetavg
NL%IMETRAD = mymetrad
NL%INITIAL_CO2 = myatmco2
!---------------------------------------------------------------------------------------!
Expand Down
34 changes: 0 additions & 34 deletions ED/Template/scripts/SLURM/spawn_poly.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1504,205 +1504,171 @@ do
metdriverdb="${fullscen}/Bananal/Bananal_HEADER"
metcyc1=2004
metcycf=2006
imetavg=1
;;
Brasilia)
metdriverdb="${fullscen}/Brasilia/Brasilia_HEADER"
metcyc1=2006
metcycf=2012
imetavg=1
;;
Caxiuana)
metdriverdb="${fullscen}/Caxiuana/Caxiuana_HEADER"
metcyc1=1999
metcycf=2003
imetavg=1
;;
ERA5_CHIRPS)
metdriverdb="${fullscen}/${iscenario}_HEADER"
metcyc1=1981
metcycf=2019
imetavg=1
;;
ERAINT_CHIRPS)
metdriverdb="${fullscen}/${iscenario}_HEADER"
metcyc1=1981
metcycf=2017
imetavg=2
;;
ERAINT_NATIVE)
metdriverdb="${fullscen}/${iscenario}_HEADER"
metcyc1=1979
metcycf=2017
imetavg=2
;;
ERAINT_MSWEP2)
metdriverdb="${fullscen}/${iscenario}_HEADER"
metcyc1=1979
metcycf=2016
imetavg=2
;;
Fazenda_Nossa_Senhora)
metdriverdb="${fullscen}/Fazenda_Nossa_Senhora/Fazenda_Nossa_Senhora_HEADER"
metcyc1=1999
metcycf=2002
imetavg=1
;;
Harvard)
metdriverdb="${fullscen}/Harvard/Harvard_HEADER"
metcyc1=1992
metcycf=2003
imetavg=3
;;
Laegern)
metdriverdb="${fullscen}/Laegern/Laegern_HEADER"
metcyc1=2006
metcycf=2016
imetavg=1
;;
Manaus_Km34)
metdriverdb="${fullscen}/Manaus_Km34/Manaus_Km34_HEADER"
metcyc1=1999
metcycf=2006
imetavg=1
;;
MERRA2_CHIRPS)
metdriverdb="${fullscen}/${iscenario}_HEADER"
metcyc1=1981
metcycf=2017
imetavg=3
;;
MERRA2_MSWEP2)
metdriverdb="${fullscen}/${iscenario}_HEADER"
metcyc1=1980
metcycf=2016
imetavg=3
;;
MERRA2_NATIVE)
metdriverdb="${fullscen}/${iscenario}_HEADER"
metcyc1=1980
metcycf=2017
imetavg=3
;;
Natal)
metdriverdb="${fullscen}/Natal/Natal_HEADER"
metcyc1=2009
metcycf=2012
imetavg=1
;;
Paracou)
metdriverdb="${fullscen}/Paracou/Paracou_HEADER"
metcyc1=2004
metcycf=2014
imetavg=1
;;
Pe-de-Gigante)
metdriverdb="${fullscen}/Pe-de-Gigante/Pe-de-Gigante_HEADER"
metcyc1=2001
metcycf=2003
imetavg=1
;;
Petrolina)
metdriverdb="${fullscen}/Petrolina/Petrolina_HEADER"
metcyc1=2004
metcycf=2012
imetavg=1
;;
PGMF3_CHIRPS)
metdriverdb="${fullscen}/${iscenario}_HEADER"
metcyc1=1981
metcycf=2016
imetavg=3
;;
PGMF3_MSWEP2)
metdriverdb="${fullscen}/${iscenario}_HEADER"
metcyc1=1979
metcycf=2016
imetavg=3
;;
PGMF3_NATIVE)
metdriverdb="${fullscen}/${iscenario}_HEADER"
metcyc1=1979
metcycf=2016
imetavg=3
;;
Rebio_Jaru)
metdriverdb="${fullscen}/Rebio_Jaru/Rebio_Jaru_HEADER"
metcyc1=1999
metcycf=2002
imetavg=1
;;
Santarem_Km67)
metdriverdb="${fullscen}/Santarem_Km67/Santarem_Km67_HEADER"
metcyc1=2001
metcycf=2011
imetavg=1
;;
Santarem_Km77)
metdriverdb="${fullscen}/Santarem_Km77/Santarem_Km77_HEADER"
metcyc1=2001
metcycf=2005
imetavg=1
;;
Santarem_Km83)
metdriverdb="${fullscen}/Santarem_Km83/Santarem_Km83_HEADER"
metcyc1=2000
metcycf=2003
imetavg=1
;;
Sheffield)
metdriverdb=${fullscen}/${shefhead}
metcyc1=1969
metcycf=2008
imetavg=2
;;
Tanguro_Burn)
metdriverdb="${fullscen}/Tanguro_Burn/Tanguro_Burn_HEADER"
metcyc1=2008
metcycf=2018
imetavg=1
;;
Tanguro_Ctrl)
metdriverdb="${fullscen}/Tanguro_Ctrl/Tanguro_Ctrl_HEADER"
metcyc1=2008
metcycf=2018
imetavg=1
;;
Tonzi)
metdriverdb="${fullscen}/Tonzi/Tonzi_HEADER"
metcyc1=2000
metcycf=2010
imetavg=1
;;
WFDE5_CHIRPS)
metdriverdb="${fullscen}/${iscenario}_HEADER"
metcyc1=1981
metcycf=2018
imetavg=2
;;
WFDEI_CHIRPS)
metdriverdb="${fullscen}/${iscenario}_HEADER"
metcyc1=1981
metcycf=2016
imetavg=1
;;
WFDEI_CRUP)
metdriverdb="${fullscen}/${iscenario}_HEADER"
metcyc1=1979
metcycf=2016
imetavg=1
;;
WFDEI_GPCC)
metdriverdb="${fullscen}/${iscenario}_HEADER"
metcyc1=1979
metcycf=2016
imetavg=1
;;
WFDEI_MSWEP2)
metdriverdb="${fullscen}/${iscenario}_HEADER"
metcyc1=1979
metcycf=2016
imetavg=1
;;
*)
echo "Met driver: ${metdriver}"
Expand Down
15 changes: 0 additions & 15 deletions ED/run/ED2IN
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1966,20 +1966,6 @@ $ED_NL
! IMETCYCF -- Last year for which meteorological driver files exist. In addition, !
! the model assumes that files exist for all years between METCYC1 and !
! METCYCF. !
! IMETAVG -- How the input radiation was originally averaged. You must tell this !
! because ED-2.1 can make a interpolation accounting for the cosine of !
! zenith angle. !
! -1. (Deprecated) I don't know, use linear interpolation. !
! 0. No average, the values are instantaneous !
! 1. Averages ending at the reference time !
! 2. Averages beginning at the reference time !
! 3. Averages centred at the reference time !
! !
! IMPORTANT: The user must obtain the correct information for each !
! meteorological driver before running the model, and set !
! this variable consistently. Inconsistent settings are !
! known to cause numerical instabilities, particularly at !
! around sunrise and sunset times. !
! !
! IMETRAD -- What should the model do with the input short wave radiation? !
! 0. (ED-2.2 default, when radiation components were measured) !
Expand All @@ -2006,7 +1992,6 @@ $ED_NL
NL%ISHUFFLE = 0
NL%METCYC1 = 2004
NL%METCYCF = 2014
NL%IMETAVG = 1
NL%IMETRAD = 5
NL%INITIAL_CO2 = 410.
!---------------------------------------------------------------------------------------!
Expand Down
1 change: 1 addition & 0 deletions ED/run/ED_MET_DRIVER_HEADER
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
1
/home/rknox/Datasets/CCSM3/H5/ccsm3_surf_SA_
51 51 1.5 1.5 -100.75 -60.0
1
15
'lat' 'lon' 'vbdsf' 'vddsf' 'prate' 'dlwrf' 'pres' 'ugrd' 'vgrd' 'sh' 'tmp' 'hgt' 'co2' 'nbdsf' 'nddsf'
00.00 00.00 21600.0 21600.0 21600.0 21600.0 21600.0 21600.0 21600.0 21600.0 21600.0 50.0 21600.0 21600.0 21600.0
Expand Down
Loading
Loading