CI green proof for PR #438 (do not merge) - #2
Closed
ECYaz wants to merge 2 commits into
Closed
Conversation
Nothing verified a pull request. The only CI config was a Travis file pinned to PHP 5.3 running phpunit against test/travis/, a directory that no longer exists, alongside a .gitmodules pointing at git://github.com/phpbb/phpbb3.git. Neither has run in years and there is no submodule gitlink left in the tree, so both are removed. There are no tests in the repo, so this is not a test suite: lint php -l on 7.4, 8.1, 8.2 and 8.3 coding standards phpBB's extension ruleset via phpcs-changed composer composer validate The coding standards job reports only violations a pull request introduces. The whole tree currently carries 175 pre-existing errors across 75 files, so a tree-wide check would be permanently red, and checking whole changed files would fail anyone touching a legacy file on violations they did not write. Comparing against the base branch keeps new code clean without demanding a cleanup first.
Pin the jobs to ubuntu-22.04, matching phpBB's own 3.3.x workflows, so the PHP 7.4 job cannot break when GitHub advances ubuntu-latest. Collect the changed files with mapfile instead of an unquoted string so paths survive word splitting, and drop the shellcheck suppression the old expansion needed.
Owner
Author
|
Run complete, all green: https://github.com/ECYaz/customisation-db/actions/runs/30504954698 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trigger run only, for phpbb#438.