EAMxx: Replacing temporary views with the emaxx buffer. #7199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odiazib
added
MAM4xx
bartgol
approved these changes
Apr 2, 2025
odiazib
changed the title
mahf708
approved these changes
Apr 2, 2025
odiazib
force-pushed
the
emaxx/mam4_buffer
branch
from
772fbe1 to
fe47ffa
Compare
odiazib
force-pushed
the
emaxx/mam4_buffer
branch
from
fe47ffa to
1ea1a69
Compare
bartgol
approved these changes
Apr 5, 2025
singhbalwinder
approved these changes
Apr 9, 2025
singhbalwinder
added a commit
that referenced
this pull request
Apr 9, 2025
…#7199) EAMxx: Replacing temporary views with the emaxx buffer. I modified the mam4::buffer to be utilized across all mam4 processes by making the number of buffer.scratch processes dependent on the layout. These variables are specifically designed for the ncol x nlev layout. For other layout types, I introduced buffer.temporary_views, which is a 1D view. To configure buffer.temporary_views, I implemented the methods get_len_temporary_views and init_temporary_views in each process. Additionally, I did not replace views that need to be reset to zero each time run_impl is invoked. [BFB] * odiazib/emaxx/mam4_buffer: EAMxx: Fixing the typo from temporal to temporary. EMAxx: clang-format EMAxx: Fixing the failing test by using views instead of buffer_. EAMxx: Remove buffer.work and move the temporal views size inside buffer_size. EAMxx: Using buffer_ to set temporal views in wetscav. EAMxx: Using buffer_ to set temporal views in optics. EAMxx: Using buffer_ to set temporal views in microphysics. EAMxx: Using buffer_ to set temporal views in dry deposition. EAMxx: Using buffer_ to set temporal views in ACI. EAMxx: Utilizing the buffer within the ACI intefface. EAMxx: Modifying the mam4xx buffer to set the number of scratch files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I modified the
mam4::bufferto be utilized across allmam4processes by making the number ofbuffer.scratchprocesses dependent on the layout. These variables are specifically designed for thencol x nlevlayout. For other layout types, I introducedbuffer.temporary_views, which is a 1D view. To configurebuffer.temporary_views, I implemented the methodsget_len_temporary_viewsandinit_temporary_viewsin each process. Additionally, I did not replace views that need to be reset to zero each timerun_implis invoked.[BFB]