Skip to content

Commit

Permalink
icon for linux dist
Browse files Browse the repository at this point in the history
  • Loading branch information
@e9gille
e9gille committed Apr 23, 2018
1 parent 0351677 commit 50bab66
Showing 1 changed file with 0 additions and 0 deletions.
Binary file modified D.png
View file
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

12 comments on commit 50bab66

@jayfoad
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@e9gille what was this commit for? You changed D.png from 1024x1024 to 64x64, but it's used as the source for the Windows and Mac icon files (D.ico and D.icns), which contain icons up to 512x512. See D.sh for the conversion code.

@e9gille
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, I missed that it was used as a source file for the others. We need a 64x64.png for the linux distro.

Does that tool generate a good result? When I used the 512x512 png it appeared grainy in linux (which downsized it dynamically).

I see the resulting files are deleted after creating the mac and win files. How about we put all files in a sub folder and keep at least the 64x64 version for linux?

@JasonRivers
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For linux in the past I have simply used an SVG and rendered what is needed at the time, (either build or runtime depending on what's needed). Would this be a better "source" to use to get the multiple sizes?

@e9gille
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I understand the linux runtime is best served a 64x64 png. If the various formats are generated from an svg source that would probably yield the highest quality result. Is that an option?

@jayfoad
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linux probably has different requirements depending on which flavour you're running :-( E.g. from the GNOME Human Interface Guidelines:

It is essential your application has a 256x256 px icon. With the advent of high-DPI displays, a 512x512 px variant is recommended.

@jayfoad
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about we put all files in a sub folder and keep at least the 64x64 version for linux?

Sure (or whatever size(s) we decide is best for Linux).

If the various formats are generated from an svg source that would probably yield the highest quality result. Is that an option?

Sure. But I don't know where D.png came from in the first place, or whether we have an SVG version of it. I will ask around...

@e9gille
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linux probably has different requirements depending on which flavour you're running :-( E.g. from the GNOME Human Interface Guidelines:

Oh no! I didn't know, I'm on Ubuntu and 64 seemed the way to go on that.

Sure. But I don't know where D.png came from in the first place, or whether we have an SVG version of it. I will ask around...

I would ask Mike, he's been feeding me the files, but he doesn't seem to be available today.

@jayfoad
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually D.svg looks up-to-date. I guess D.png was generated from D.svg, though I don't know for sure.

@jayfoad
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What "application icon" are we talking about? We already use D.svg on Linux: see packagescripts/linux/packageLinux.sh which copies it into /usr/share/icons/...

I guess you're talking about the "icon" property that we pass into Electron's BrowserWindow:
https://github.com/electron/electron/blob/master/docs/api/browser-window.md#class-browserwindow
I'm not sure what the recommendations are for that one. It does say "you can also leave it undefined so the executable's icon will be used"...

@e9gille
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm lost. If I don't set the icon for the main BrowserWindow on linux I don't get any icon in the tray (neither runtime nor during dev).

I'm now testing again and can't even seem to run RIDE using electron 1.8.4 (I just get a blue screen, but I can see the dom is there if I use the dev tools). What Linux distro are you running?

@jayfoad
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ubuntu 17.10.

@e9gille
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I've tested on both 16.04 and 17.10 (using HyperV on Win10) and for some reason it isn't doing it for me. Not sure what has changed to cause the issue.

When I check the runtime versions I just run the node mk command, I haven't checked the package scripts. Clearly they do more to get things set up, including sorting out the icons. I'll just humbly back away from this area and leave it to the pros. I can recover the 512 png if it is still reuired (sounds like it is).

Please sign in to comment.