fix: not enabled 'time.datetime_formatter' #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #117 +/- ##
============================================
- Coverage 82.14% 81.47% -0.67%
- Complexity 290 294 +4
============================================
Files 30 30
Lines 1327 1247 -80
============================================
- Hits 1090 1016 -74
+ Misses 237 231 -6 ☔ View full report in Codecov by Sentry. |
kl3sk
reviewed
Feb 26, 2024
| return $this->dateTimeFormatter->formatDiff($dateTime); | ||
| } | ||
|
|
||
| return ''; |
There was a problem hiding this comment.
Why not returning a date string in this case ?
$datetime->format('Y-m-d')
There was a problem hiding this comment.
That would be duplicate the info in this format twice or not?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#99
Update: CI is green now.