-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix link failure when building on Fedora 64bit #1
Conversation
Hm, interesting I would assume cmake create would pick up correct search location automatically, but that's not the case then? |
If possible, can you shall full build log(cargo build --verbose) from your machine where you encounter issue? |
|
CMake itself, I think, is doing the right thing. The issue is that it is assumed that the build directory contains: Somehow CMake picks up some environmental setting and creates a Of note that this does not happen on Ubuntu since it uses a different library differentiation technique. |
Hm looking back I forgot that cmake crate just returns root of installation directoy I'm thinking instead of doing rename, we should add |
8f16b53
to
02841bb
Compare
Fedora and other Linux distributions tend to use `lib64` as the library directory and when building and installing the native library with CMake the directory structure in the prefix conforms to this standard. This makes the linking fail since the search directory for `libnng` is set to `lib`. This patch adds `lib64` to the library search path on Linux. The same issue is also present for `mbedtls` and was fixed there as well.
Thanks, I will merge and release it later after work |
Released 1.9.0-beta.2 (will release nng-c bump a bit later) |
Thanks! |
Fix link failure when building on Fedora 64bit
Fedora and other Linux distributions tend to use
lib64
as the library directory and when building and installing the native library with CMake the directory structure in the prefix conforms to this standard.This makes the linking fail since the search directory for
libnng
is set tolib
.This patch adds
lib64
to the library search path on Linux.The same issue is also present for
mbedtls
and was fixed there as well.