Skip to content

Fix unit test #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Fix unit test #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b2e6755
pin ubuntu version for python 3.6 & 3.7
MalteKurz Dec 25, 2023
7bd9361
use named function arguments when calling the init of the superclass
MalteKurz Dec 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions .github/workflows/pytest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,15 +16,16 @@ on:
jobs:
build:

runs-on: ubuntu-latest
runs-on: ${{ matrix.config.os }}

strategy:
matrix:
config:
- {python-version: '3.6', doubleml-version: 'release'}
- {python-version: '3.7', doubleml-version: 'release'}
- {python-version: '3.8', doubleml-version: 'release'}
- {python-version: '3.8', doubleml-version: 'dev'}
- {python-version: '3.9', doubleml-version: 'release'}
- {os: 'ubuntu-20.04', python-version: '3.6', doubleml-version: 'release'}
- {os: 'ubuntu-20.04', python-version: '3.7', doubleml-version: 'release'}
- {os: 'ubuntu-latest', python-version: '3.8', doubleml-version: 'release'}
- {os: 'ubuntu-latest', python-version: '3.8', doubleml-version: 'dev'}
- {os: 'ubuntu-latest', python-version: '3.9', doubleml-version: 'release'}

steps:
- uses: actions/checkout@v3
Expand Down
24 changes: 12 additions & 12 deletions doubleml_serverless/double_ml_data_aws.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,12 @@ def __init__(self,
x_cols=None,
z_cols=None,
use_other_treat_as_covariate=True):
super().__init__(data,
y_col,
d_cols,
x_cols,
z_cols,
use_other_treat_as_covariate)
super().__init__(data=data,
y_col=y_col,
d_cols=d_cols,
x_cols=x_cols,
z_cols=z_cols,
use_other_treat_as_covariate=use_other_treat_as_covariate)
self._bucket = bucket
self._file_ending = os.path.splitext(file_key)[1]
assert self._file_ending in ['.csv']
Expand Down Expand Up @@ -80,12 +80,12 @@ def __init__(self,
x_cols=None,
z_cols=None,
use_other_treat_as_covariate=True):
super().__init__(data,
y_col,
d_cols,
x_cols,
z_cols,
use_other_treat_as_covariate)
super().__init__(data=data,
y_col=y_col,
d_cols=d_cols,
x_cols=x_cols,
z_cols=z_cols,
use_other_treat_as_covariate=use_other_treat_as_covariate)
self._data_json = data.to_json(orient="columns")

@property
Expand Down