Skip to content

Commit

Permalink
Upgrade to Netty 4.1
Browse files Browse the repository at this point in the history
Issue: SPR-14143
  • Loading branch information
jhoeller committed Apr 11, 2016
1 parent 4407bd7 commit 21e4ac1
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 10 deletions.
4 changes: 2 additions & 2 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -63,9 +63,9 @@ configure(allprojects) { project ->
ext.jsonpathVersion = "2.2.0"
ext.jtaVersion = "1.2"
ext.junitVersion = "4.12"
ext.nettyVersion = "4.0.36.Final"
ext.okhttp3Version = "3.2.0"
ext.nettyVersion = "4.1.0.CR7"
ext.okhttpVersion = "2.7.5"
ext.okhttp3Version = "3.2.0"
ext.openjpaVersion = "2.4.1"
ext.poiVersion = "3.14"
ext.protobufVersion = "2.6.1"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright 2002-2015 the original author or authors.
* Copyright 2002-2016 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -42,8 +42,8 @@
import org.springframework.util.concurrent.SettableListenableFuture;

/**
* {@link org.springframework.http.client.ClientHttpRequest} implementation that uses
* Netty 4 to execute requests.
* {@link org.springframework.http.client.ClientHttpRequest} implementation
* that uses Netty 4 to execute requests.
*
* <p>Created via the {@link Netty4ClientHttpRequestFactory}.
*
Expand Down Expand Up @@ -148,8 +148,8 @@ private FullHttpRequest createFullHttpRequest(HttpHeaders headers) {
FullHttpRequest nettyRequest = new DefaultFullHttpRequest(HttpVersion.HTTP_1_1,
nettyMethod, this.uri.toString(), this.body.buffer());

nettyRequest.headers().set(HttpHeaders.HOST, uri.getHost());
nettyRequest.headers().set(HttpHeaders.CONNECTION, io.netty.handler.codec.http.HttpHeaders.Values.CLOSE);
nettyRequest.headers().set(HttpHeaders.HOST, this.uri.getHost());
nettyRequest.headers().set(HttpHeaders.CONNECTION, "close");

for (Map.Entry<String, List<String>> entry : headers.entrySet()) {
nettyRequest.headers().add(entry.getKey(), entry.getValue());
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright 2002-2014 the original author or authors.
* Copyright 2002-2016 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -28,8 +28,8 @@
import org.springframework.util.Assert;

/**
* {@link org.springframework.http.client.ClientHttpResponse} implementation that uses
* Netty 4 to execute requests.
* {@link org.springframework.http.client.ClientHttpResponse} implementation
* that uses Netty 4 to parse responses.
*
* @author Arjen Poutsma
* @since 4.1.2
Expand All @@ -56,11 +56,13 @@ public Netty4ClientHttpResponse(ChannelHandlerContext context, FullHttpResponse


@Override
@SuppressWarnings("deprecation")
public int getRawStatusCode() throws IOException {
return this.nettyResponse.getStatus().code();
}

@Override
@SuppressWarnings("deprecation")
public String getStatusText() throws IOException {
return this.nettyResponse.getStatus().reasonPhrase();
}
Expand Down

0 comments on commit 21e4ac1

Please sign in to comment.