Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the project's README #19

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Conversation

polybluez
Copy link
Contributor

@polybluez polybluez commented Feb 11, 2025

"Re-opening" of #18. I wanted to open the PR back again, but faced some technical issues :(

@cher-nov cher-nov requested review from cher-nov and removed request for cher-nov February 11, 2025 14:35
Copy link
Member

@cher-nov cher-nov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great and long-awaited work, thank you!

  1. Please restore COPYING in its current form. It should be readable as plain text.

  2. Rename README.md to ReadMe.md.

  3. Merge everything into one ReadMe file. This is not the case when the GitHub repository also serves as a project page. We're using it only as a development resource, so it is better to focus on technical aspects here.

  4. No need for a FAQ at the moment. It's an excessive text that requires separate care and effort for maintenance, which we currently would like to avoid.

README.md Outdated
@@ -0,0 +1,41 @@
# Doom2D Forever
**Doom2D Forever** is a recreation of the classic Doom 2D (1993) game.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. No need to write project name twice.
  2. The year of original release is already indicated in the repo description (also it's 1996, not 1993).
Suggested change
**Doom2D Forever** is a recreation of the classic Doom 2D (1993) game.
A recreation of the classic [Doom2D](https://doomwiki.org/wiki/Doom_2D) game from the late DOS era, a simulacrum of a parody - just as it should be.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Yes need. Not everyone reads the description, and the README file should also stand on its own.
  2. Not everyone reads the description, and the README file should also stand on its own. My bad about the year.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Yes need. Not everyone reads the description, and the README file should also stand on its own.

I mean, there's already a heading with project name, so there's no need to start the paragraph with it again.

README.md Outdated
Comment on lines 5 to 6
<p align="center">
<img src="https://doom2d.org/doom2d_forever/about/DFsml.jpg" alt="Doom2D Forever, SuperDM, 640x480.">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need more screenshots (5-7 will be enough, I guess) with static small previews instead of resized originals and left alignment. I'm going to upload them at doom2d.org and give you links a bit later.

Suggested change
<p align="center">
<img src="https://doom2d.org/doom2d_forever/about/DFsml.jpg" alt="Doom2D Forever, SuperDM, 640x480.">
<p align="center">
<img src="https://doom2d.org/doom2d_forever/about/DFsml.jpg" alt="Doom2D Forever, SuperDM, 640x480.">

README.md Outdated
Comment on lines 12 to 19
# Features
- **Online multiplayer** with DM, CTF and COOP gamemodes!
- Compared to Doom2D 1.30, the resolution of textures and sprites has been doubled
- Bots (very aggressive ones!) are available both in singleplayer and multiplayer.
- Russian and English localization. Да, в игре конечно же есть русский язык.
- Multiplatform: runs on Windows, Android, macOS, Linux.
- Cross-platform play: if your platform supports multiplayer, rest assured you can play with everybody.
- A map editor!
Copy link
Member

@cher-nov cher-nov Feb 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this section. Any promotion should go to the official website.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? There is no need for promotion if it's for developers? Besides, regular people visit GitHub too.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? There is no need for promotion if it's for developers? Besides, regular people visit GitHub too.

It's not so much about promotion, but about maintaining a clear distinction between community activity and the development process.

Copy link
Contributor Author

@polybluez polybluez Feb 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not so much about promotion, but about maintaining a clear distinction between community activity and the development process.

Ultimately, it's your call. But I would argue that screenshots fall under promotion and community activity too, and therefore should be removed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I would argue that screenshots fall under promotion and community activity too, and therefore should be removed.

We are talking about ReadMe here. As part of a brief introduction, they are more than adequate, and the visual information is worth a wall of text.

README.md Outdated
</p>

# Download and install
Please follow the [**installation guide**](docs/INSTALL.md) to download and install Doom2D Forever.
Copy link
Member

@cher-nov cher-nov Feb 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Please follow the [**installation guide**](docs/INSTALL.md) to download and install Doom2D Forever.
Pre-built binaries of the latest commit (snapshot) are currently available for the following platforms and operating systems:
- **Windows** Download a ZIP-archive, either [Windows x64 (64-bit)](https://github.com/Doom2D/nixandroid/releases/latest/download/doom2df-mingw64.zip) or [**Windows x86 (32-bit)**](https://github.com/Doom2D/nixandroid/releases/latest/download/doom2df-mingw32.zip).
- **Linux** ...
- **Android** Download the [**Android APK**](https://github.com/Doom2D/nixandroid/releases/latest/download/doom2df-android.apk).
- **macOS** Download the [**macOS ZIP archive**](https://github.com/Doom2D/nixandroid/releases/latest/download/doom2df-x86_64-apple-darwin.zip). Currently only x86-64 (Intel) binaries are provided.

Copy link
Contributor Author

@polybluez polybluez Feb 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes need. It would bloat the page if (when) more installables would be added to the list. Think Windows .MSIX installers, macOS homebrew, MacPorts, macOS ZIP bundle, macOS native app, Linux Flatpak, Linux Arch, Linux ZIP archive, Linux AppImage, FreeBSD, OpenBSD, NetBSD, Solaris, Haiku, etc.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not arguing. Let's solve problems as they come.

README.md Outdated
Comment on lines 21 to 27
# Copyright
All rights for the resources belong to ID Software. We do not encourage and do not support any form of illegal usage of them.

# License
This project is licensed under the [**GNU General Public License v3.0**](https://github.com/Doom2D/Doom2D-Forever/blob/master/COPYING).

Initially, the project was developed on [**repo.or.cz**](https://repo.or.cz/d2df-sdl.git/).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Copyright
All rights for the resources belong to ID Software. We do not encourage and do not support any form of illegal usage of them.
# License
This project is licensed under the [**GNU General Public License v3.0**](https://github.com/Doom2D/Doom2D-Forever/blob/master/COPYING).
Initially, the project was developed on [**repo.or.cz**](https://repo.or.cz/d2df-sdl.git/).
# Disclaimer
This game is a fair-use parody, licensed _strictly_ under terms of the [**GNU General Public License v3.0**](https://github.com/Doom2D/Doom2D-Forever/blob/master/COPYING).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kinda cringe, but OK.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, are you sure you want to use such strong of a word as strictly? :) As I understand, Doom2D Forever was re-licensed in 2016 under GPL v3, but previous contributors were not approached about re-licensing their changes. And then it was also changed to GPL v3 only, without approaching previous contributors first.

Copy link
Member

@cher-nov cher-nov Feb 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, are you sure you want to use such strong of a word as strictly? :)

Yes, as it is legal language. See this, for example: https://opensource.stackexchange.com/questions/11457/is-it-possible-that-a-future-gpl-version-removes-copyleft

but previous contributors were not approached about re-licensing their changes

They were, assuming current "Credits" screen.

And then it was also changed to GPL v3 only, without approaching previous contributors first.

Which is fine AFAIK, since this only restricts further a priori multi-licensing, while not being a relicensing by itself.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but previous contributors were not approached about re-licensing their changes

They were, assuming current "Credits" screen.

I also have a legally significant contribution, but I'm not in the "Credits" screen! Don't forget to approach me if you want to make a re-licensing decision!

Copy link
Contributor Author

@polybluez polybluez Feb 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, are you sure you want to use such strong of a word as strictly? :)

Yes, as it is legal language. See this, for example: https://opensource.stackexchange.com/questions/11457/is-it-possible-that-a-future-gpl-version-removes-copyleft

Nevermind. I thought you wanted to emphasize that the game is licensed under GPL v3.0 :)

@polybluez
Copy link
Contributor Author

Merge everything into one ReadMe file. This is not the case when the GitHub repository also serves as a project page. We're using it only as a development resource, so it is better to focus on technical aspects here.

Why not? @Jabberwock-RU всё равно не хочет заниматься лендингом и сайтом. Это легко понять, если посмотреть в веб-архив за последние 7 лет и не увидеть на сайте никаких изменений вообще.

@cher-nov
Copy link
Member

Why not?

Because at this point I want to see the repository as lightweight as possible, focusing primarily on technical issues of development and building, rather than attention-grabbing.

@Jabberwock-RU всё равно не хочет заниматься лендингом и сайтом. Это легко понять, если посмотреть в веб-архив за последние 7 лет и не увидеть на сайте никаких изменений вообще.

Не думаю, что здесь подходящее место для обсуждения этого.

@polybluez
Copy link
Contributor Author

polybluez commented Feb 11, 2025

Why not?

Because at this point I want to see the repository as lightweight as possible, focusing primarily on technical issues of development and building, rather than attention-grabbing.

I'm just wondering where exactly the promotion should take place, because if it's not at the GitHub page, it sure as hell is not taking place at the project's website.

BTW, which, sans the forum, could easily be redone as a static GitHub Pages deployment!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants